Compatible with Django-Pipeline >= 1.6.x, fixed issue with Permission…

[solkaz]

• Commands that are passed int execute_command are now tuples instead of strings, which is what Django-Pipeline expects.
• Fixed an issue that was causing PermissionErrors; the first element in command cannot be an empty string, so it will check for that. Becomes unnecessary after this PR is merged
• Fixed the is_outdated method, as output isn't returned from execute_command so it's captured as stdout_captured
• Simplified some of the logic

[j0hnsmith]

Looks great, does this mean that django-pipeline-browserify will only be compatible with specific versions of django-pipeline (eg 1.6+)? Does README.rst need to be updated?

[solkaz]

I believe so, this commit had changed command to pass a tuple to execute_command, because shell=True was removed from subprocess.Popen. There's also this commit that places all pipeline settings into a dictionary. So, I would say that it's compatible with 1.6+, and yes, the readme needs to be updated.

[frewsxcv]

Strings should be compared by value, not reference, so this should be if command[0] == '':.

[frewsxcv]

For the record, jazzband/django-pipeline#590 just merged.

[solkaz]

Addressed the comparison issues @frewsxcv

[solkaz]

Removed the check for an empty first argument as the PR in Django-Pipeline was merged.

[frewsxcv]

Removed the check for an empty first argument as the PR in Django-Pipeline was merged.

Considering a new django-pipeline release hasn't happened yet, does it make sense to remove it yet?

[solkaz]

Yeah, that doesn't make sense. I've removed the commit to keep the check

[frewsxcv]

@solkaz New django-pipeline version is out, so that commit could be added again ;)

jazzband/django-pipeline@b0f83b9

[frewsxcv]

Could also bump the required version in setup.py to 1.6.9 if we're going to rely on the 1.6.9 change

[solkaz]

Adding it back now 🎉 Will also update setup.py

[solkaz]

Both commits have been uploaded

[solkaz]

@j0hnsmith could you merge this now that django-pipeline has been updated?

[frewsxcv]

Alternatively, if you're looking for help from volunteers like myself or solkaz for maintaining this awesome project, let us know! I'd be happy to help!

[j0hnsmith]

Thanks @solkaz

[j0hnsmith]

@frewsxcv Thanks for the offer, I've invited you to be a collaborator.