[CS2] destructured nested defaults [fixes #4566] #4574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GeoffreyBooth I actually just stumbled on another similar nested destructuring bug eg So I added another commit to suppress the |
connec
reviewed
Jun 14, 2017
| @@ -1810,7 +1821,7 @@ exports.Assign = class Assign extends Base | |||
| answer = compiledName.concat @makeCode(" #{ @context or '=' } "), val | |||
| # Per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment#Assignment_without_declaration, | |||
| # if we’re destructuring without declaring, the destructuring assignment must be wrapped in parentheses. | |||
| if o.level > LEVEL_LIST or (isValue and @variable.base instanceof Obj and not @param) | |||
| if o.level > LEVEL_LIST or (isValue and @variable.base instanceof Obj and not @nestedLhs and not @param) | |||
There was a problem hiding this comment.
I take it @variable.base.lhs instead if @nestedLhs is not adequate (and/or desirable) here?
There was a problem hiding this comment.
@connec nope it seems to interfere w/ the wrapping in parens of top-level destructured object assigns. Not crystal clear on the different nested Obj/Assign structures so there may be a way do it without introducing nestedLhs but that's the way I found to distinguish the top-level Assigns from the nested ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4566
Added recursive assignment of
@lhsto destructured objects (corresponding to the recursive assignment of@lhsthat was already there for arrays)Looks like this won't cause a merge conflict with #4493