Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS2] Lexer: Destructuring with nested default values #4566

Closed
helixbass opened this issue Jun 10, 2017 · 4 comments
Closed

[CS2] Lexer: Destructuring with nested default values #4566

helixbass opened this issue Jun 10, 2017 · 4 comments
Labels
fixed
Milestone
2.0.0

Comments

@helixbass
Copy link
Collaborator

@GeoffreyBooth I just ran into something that broke (I assume unintentionally) as a result of #4478: eg ({a: {b = 1}}) -> compiled ok before this PR but gives error: unexpected = after. This destructuring also breaks in a destructured assignment: {a: {b = 1}} = c also gives error: unexpected =
@GeoffreyBooth GeoffreyBooth changed the title broken destructuring w/ nested defaults on 2 [CS2] Lexer: Destructuring with nested default values Jun 11, 2017
@GeoffreyBooth GeoffreyBooth added this to the 2.0.0 milestone Jun 11, 2017
@GeoffreyBooth
Copy link
Collaborator

@helixbass you feel like taking a crack at fixing it? Maybe after #4493 is finished?

@helixbass
Copy link
Collaborator Author

@GeoffreyBooth sure

helixbass added a commit to helixbass/copheescript that referenced this issue Jun 14, 2017
@helixbass
destructured nested defaults [fixes jashkenas#4566]
b6823be
@helixbass helixbass mentioned this issue Jun 14, 2017
Merged
@zdenko
Copy link
Collaborator

zdenko commented Jun 20, 2017

@GeoffreyBooth @helixbass this is fixed in my last commit.
@connec reported the same error on #4493 yesterday.

GeoffreyBooth pushed a commit that referenced this issue Jun 21, 2017
@GeoffreyBooth
[CS2] destructured nested defaults [fixes #4566] (#4574)
26f6fa6 
* destructured nested defaults [fixes #4566]

* don't parenthesize nested assigns
@GeoffreyBooth GeoffreyBooth added fixed and removed bug labels Jun 21, 2017
@GeoffreyBooth
Copy link
Collaborator

@zdenko just noticed your comment. Sorry, I already merged the other PR in. I guess merge 2 into your branch and resolve conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@helixbass @GeoffreyBooth @zdenko