Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2] Destructuring #4478

Merged
merged 21 commits into from
Apr 6, 2017
+952 −645
Merged

[CS2] Destructuring #4478

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
59959a6
Output simple array destructuring assignments to ES2015
Mar 30, 2017
b9f8f5d
Output simple object destructured assignments to ES2015
Mar 30, 2017
066071f
Compile shorthand object properties to ES2015 shorthand properties
Mar 30, 2017
2e0dab3
Compile default values in destructured assignment to ES2015
Apr 1, 2017
a196614
Rename `wrapInBraces` to `wrapInParentheses`, and `compilePatternMatc…
GeoffreyBooth Apr 2, 2017
b11ba7f
Don’t confuse the syntax highlighter
GeoffreyBooth Feb 5, 2017
c5f7279
Comment Assign::compilePatternMatch a bit
lydell Feb 5, 2017
93c8f8e
Assignment expressions in conditionals are a bad practice
GeoffreyBooth Feb 9, 2017
8840aa9
Optional check for existence that only checks `!== undefined`, not `!…
GeoffreyBooth Mar 29, 2017
7786899
The fallback destructuring code should apply default values only if `…
GeoffreyBooth Apr 2, 2017
1e6d910
Add comments; remove unnecessary array splats in function tests
GeoffreyBooth Apr 2, 2017
6c814a0
Support destructuring in function parameters (first pass); catch dest…
GeoffreyBooth Apr 2, 2017
5fc4e19
Destructured variables in function parameter lists shouldn’t be added…
GeoffreyBooth Apr 2, 2017
770ddcd
Remove redundancy in undefined-only check for existence; fix passing …
GeoffreyBooth Apr 2, 2017
d110b9a
Fix undefined redundancy
GeoffreyBooth Apr 2, 2017
678e931
Simplify getting the variable name
GeoffreyBooth Apr 2, 2017
60f046e
Reimplement “check for existence if not undefined” without creating a…
GeoffreyBooth Apr 2, 2017
05c1f46
`Obj::isAssignable` should not mutate; pass `lhs` property in from `A…
GeoffreyBooth Apr 2, 2017
923b931
Merge branch '2' into destructuring
GeoffreyBooth Apr 3, 2017
bd8cf29
Revert changes to tests
GeoffreyBooth Apr 5, 2017
7e81fa0
Restore revised test for empty destructuring assignment
GeoffreyBooth Apr 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions lib/coffeescript/cake.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions lib/coffeescript/coffeescript.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 17 additions & 21 deletions lib/coffeescript/command.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/coffeescript/grammar.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions lib/coffeescript/helpers.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading