Code

[CS2] Destructuring#4478

Code

Merged

GeoffreyBooth merged 21 commits intojashkenas:2jashkenas/coffeescript:2from GeoffreyBooth:destructuringGeoffreyBooth/coffeescript:destructuringCopy head branch name to clipboardApr 6, 2017

+952-645

Commits

Commits on Mar 30, 2017

• Output simple array destructuring assignments to ES2015

  

  Chris Connelly

  committed
  59959a6

• Output simple object destructured assignments to ES2015

  

  Chris Connelly

  committed
  b9f8f5d

• Compile shorthand object properties to ES2015 shorthand properties

  Show description for 066071f
  

  Chris Connelly

  committed
  066071f

Commits on Apr 1, 2017

• Compile default values in destructured assignment to ES2015

  

  Chris Connelly

  committed
  2e0dab3

Commits on Apr 2, 2017

• Rename wrapInBraces to wrapInParentheses, and compilePatternMatch to compileDestructuring, for clarity; style improvements (no == or !=, etc.)

  GeoffreyBooth

  committed
  a196614

• Don’t confuse the syntax highlighter

  GeoffreyBooth

  committed
  b11ba7f

• Comment Assign::compilePatternMatch a bit

  

  lydell

  authored and

  GeoffreyBooth

  committed
  c5f7279

• Assignment expressions in conditionals are a bad practice

  GeoffreyBooth

  committed
  93c8f8e

• Optional check for existence that only checks !== undefined, not != null, to follow ES convention that default values only apply when a variable is undefined, not falsy

  GeoffreyBooth

  committed
  8840aa9

• The fallback destructuring code should apply default values only if undefined, not falsy, to follow ES spec

  GeoffreyBooth

  committed
  7786899

• Add comments; remove unnecessary array splats in function tests

  GeoffreyBooth

  committed
  1e6d910

• Support destructuring in function parameters (first pass); catch destructured reserved words

  GeoffreyBooth

  committed
  6c814a0

• Destructured variables in function parameter lists shouldn’t be added to the function body with var declarations; treat splat array function parameters the legacy way to avoid rethinking jashkena…

  Show description for 5fc4e19
  GeoffreyBooth

  committed
  5fc4e19

• Remove redundancy in undefined-only check for existence; fix passing option to check

  GeoffreyBooth

  committed
  770ddcd

• Fix undefined redundancy

  GeoffreyBooth

  committed
  d110b9a

• Simplify getting the variable name

  GeoffreyBooth

  committed
  678e931

• Reimplement “check for existence if not undefined” without creating a new operator

  GeoffreyBooth

  committed
  60f046e

• Obj::isAssignable should not mutate; pass lhs property in from Assign or Code to child arrays and objects so that those child nodes are set as allowable for destructuring

  GeoffreyBooth

  committed
  05c1f46

Commits on Apr 3, 2017

• Merge branch '2' into destructuring

  Show description for 923b931
  GeoffreyBooth

  committed
  923b931

Commits on Apr 5, 2017

• Revert changes to tests

  GeoffreyBooth

  committed
  bd8cf29

• Restore revised test for empty destructuring assignment

  GeoffreyBooth

  committed
  7e81fa0