Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4819] fixed failing to push some files to http remote #4820

Merged
merged 1 commit into from
Nov 1, 2020
Merged

[#4819] fixed failing to push some files to http remote #4820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dvc/tree/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class HTTPTree(BaseTree): # pylint:disable=abstract-method

SESSION_RETRIES = 5
SESSION_BACKOFF_FACTOR = 0.1
REQUEST_TIMEOUT = 10
REQUEST_TIMEOUT = 60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might also be not enough if the file is big enough and/or the connection is slow enough. What is the biggest file size that you are uploading? We are having a similar discussion about webdav where apparently chunked upload is not always possible and so that makes #829 more relevant. Maybe it does here too.

Copy link
Contributor Author

@simonlsk simonlsk Nov 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chunk size has never caused a problem for a single large file in my case. Only having too many concurrent files uploading would make some of them time out.
In general, with a slow enough connection, or too many concurrent jobs, some file will eventually fail to upload.
This also relates to other issues discussing the implementation of retries.

CHUNK_SIZE = 2 ** 16

def __init__(self, repo, config):
Expand Down