[#4819] fixed failing to push some files to http remote #4820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
reviewed
Nov 1, 2020
| @@ -33,7 +33,7 @@ class HTTPTree(BaseTree): # pylint:disable=abstract-method | |||
|
|
|||
| SESSION_RETRIES = 5 | |||
| SESSION_BACKOFF_FACTOR = 0.1 | |||
| REQUEST_TIMEOUT = 10 | |||
| REQUEST_TIMEOUT = 60 | |||
There was a problem hiding this comment.
This might also be not enough if the file is big enough and/or the connection is slow enough. What is the biggest file size that you are uploading? We are having a similar discussion about webdav where apparently chunked upload is not always possible and so that makes #829 more relevant. Maybe it does here too.
There was a problem hiding this comment.
The chunk size has never caused a problem for a single large file in my case. Only having too many concurrent files uploading would make some of them time out.
In general, with a slow enough connection, or too many concurrent jobs, some file will eventually fail to upload.
This also relates to other issues discussing the implementation of retries.
efiop
approved these changes
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Increased the
HTTPTree.REQUEST_TIMEOUTfrom 10 to 60 seconds, as it was not changed after implementing upload for http.Will fix #4819