Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide: expand Experiments guide #2654

Closed
wants to merge 20 commits into from
Closed

guide: expand Experiments guide #2654

wants to merge 20 commits into from

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Jul 21, 2021

Restructures the guide into an intro and a few pages.

Per #2548 (main files changed linked in each item below)

Potentially:

@jorgeorpinel jorgeorpinel self-assigned this Jul 21, 2021
@shcheklein shcheklein temporarily deployed to dvc-org-guide-exps-plmbmvr3isn July 21, 2021 08:58 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as draft July 21, 2021 09:00
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-exps-plmbmvr3isn July 28, 2021 07:12 Inactive
@jorgeorpinel jorgeorpinel changed the title guide: split Experiments guide into sub-pages guide: split Experiments guide & copy some info from cmd ref. Jul 29, 2021
@jorgeorpinel jorgeorpinel changed the title guide: split Experiments guide & copy some info from cmd ref. guide: expand Experiments guide Jul 29, 2021
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-exps-plmbmvr3isn July 29, 2021 03:53 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-exps-plmbmvr3isn July 29, 2021 03:55 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-exps-plmbmvr3isn July 29, 2021 03:56 Inactive
@jorgeorpinel jorgeorpinel changed the title guide: expand Experiments guide [nested] guide: expand Experiments guide Jul 29, 2021
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-exps-plmbmvr3isn July 29, 2021 06:03 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-exps-plmbmvr3isn July 29, 2021 06:06 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-exps-plmbmvr3isn July 29, 2021 06:07 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-exps-plmbmvr3isn July 29, 2021 06:12 Inactive
and move run-cache to guide intro (index)
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-exps-plmbmvr3isn July 29, 2021 06:25 Inactive
@jorgeorpinel
Copy link
Contributor Author

@shcheklein @iesahin this is the first in a series of cascading or nested PRs to restructure the Experiments guide and move most of the details from the command ref (for now only restructuring). Should I keep it as a draft until more PRs are open against this branch? Should we start the review process for this part? (It's ready) Thanks


_New in DVC 2.0_

`dvc exp` commands let you automatically track a variation to an established
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this PR: track a variation to an established data pipeline sounds very complicated.

dvc exp run, dvc exp show, and other dvc exp commands automatically capture and save experiment runs, including code, data, metrics, models, etc.

or even better - get rid of this sentence :) It does more harm than good to my mind.

experiments this way, as well as review, compare, and restore them later, or
roll back to the baseline. The basic workflow goes like this:

- Modify stage <abbr>parameters</abbr> or other dependencies (e.g. input data,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this PR: Modify hyperparameters (link to params), code ... etc ... we are being way too formal here again. I thinks we can sacrifice it a bit and use some common ML terminology

@shcheklein

This comment has been minimized.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-exps-i6pyd2tmqgh October 6, 2021 06:55 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-exps-i6pyd2tmqgh October 6, 2021 06:59 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-exps-i6pyd2tmqgh October 6, 2021 07:18 Inactive
@jorgeorpinel jorgeorpinel changed the title [nested] guide: expand Experiments guide guide: expand Experiments guide Oct 6, 2021
@jorgeorpinel
Copy link
Contributor Author

@iesahin @shcheklein WDYT about the changes here? Please see the description for a list (and links to the related file changes). Especially about having a dedicated DVC Experiments page to explain what experiments are and potentially go into implementation details (in the future). It would make more sense with a simplification of the Running Experiments page but let's leave that for another PR (it's a task in #2768 for now).

See https://dvc-org-guide-exps-i6pyd2tmqgh.herokuapp.com/doc/user-guide/experiment-management

p.s. Looks like nesting PRs wasn't very successful, this ended up being quite a big PR after merging a few others back into it... Sorry!

@@ -0,0 +1,36 @@
## DVC Experiments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be clear that those are DVC experiments?

also it's clear that this is about experiments

what is the actual intention behind this page?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, renaming page + copy editing makes it almost impossible to review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the section in the index is just called Experiments and I'm happy to rename it back to that. I just thought it would be clearer to "brand them" since they're special. We also say things like DVC Project, DVC Cache, and DVC Remote.

actual intention behind this page?

"...dedicated DVC Experiments page to explain what experiments are and potentially go into implementation details (in the future)." 🙂

renaming page + copy editing makes it almost impossible to review

This is a brand new page. No file was renamed in this PR. Some of it's info was extracted from the index.md.

Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. I realize it's a huge PR. That's because we wanted to try nesting PRs, but it resulted in this one being too big and losing track of which changes we already approved... But the PR description has a list of changes done with links to the files updated (4 major ones). Everything else is small copy edits and link updates.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearer to "brand them" since they're special. We also say things like DVC Project, DVC Cache

In fact we already call it "DVC Experiments" in some places e.g. there's a few instances in https://github.com/iterative/dvc.org/pull/2901/files#diff-8bac2dee1e13766aefa536c3d2fa38296dc6b09ba750fd71c9eedde61df8d1b9

cleans the slate so you can repeat the process.

## Checkpoints in source code
Every time you [reproduce](/doc/command-reference/repro) a pipeline with DVC, it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds too much for the index page? and too abrupt to be honest (even though it is in the details section)


> 📖 To learn more, see the dedicated
> [Checkpoints](/doc/user-guide/experiment-management/checkpoints) guide.
## DVC Experiments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here - it's clear that this is about dvc and about experiments - what is the intention of this subsection? what is the intention behind the index page?


### Organization patterns
### Organization Patterns
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be somewhere inside? (not on the index page)?

@shcheklein
Copy link
Member

@jorgeorpinel there are indeed too many changes at once, some of them are not that related. Could you please split this? otherwise we'll have a few reviews happening at once in one PR - it can take forever to do this :)

@jorgeorpinel
Copy link
Contributor Author

OK. I'll split this ⌛

@jorgeorpinel jorgeorpinel mentioned this pull request Oct 8, 2021
2 tasks
@jorgeorpinel
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel mentioned this pull request Oct 9, 2021
5 tasks
@jorgeorpinel
Copy link
Contributor Author

Extracted to #2909

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Oct 10, 2021

Extracted to #2910

@jorgeorpinel jorgeorpinel deleted the guide/exps branch November 4, 2021 05:28
jorgeorpinel added a commit that referenced this pull request Nov 17, 2021
* guide: Review of + link checkpoints guide
from #2654 (comment)

* guide: remove `dvc experiment` links

* guide: roll back unrelated changes
@jorgeorpinel jorgeorpinel added type: enhancement Something is not clear, small updates, improvement suggestions A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants