Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide: Sharing Experiments #2618

Merged
merged 15 commits into from
Aug 4, 2021
Merged

guide: Sharing Experiments #2618

merged 15 commits into from
Aug 4, 2021

Conversation

iesahin
Copy link
Contributor

@iesahin iesahin commented Jul 8, 2021

This PR adds a new section/page to UG:Experiment Management.

Topics to be covered

  • Adding remotes to share experiments
  • Pushing experiments in remotes
  • Listing experiments in remotes
  • Pulling experiments from remotes

Closes #2367

Moved todo to #2687

@iesahin iesahin self-assigned this Jul 8, 2021
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--dnxjz8 July 8, 2021 14:41 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--dnxjz8 July 9, 2021 19:54 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--dnxjz8 July 10, 2021 09:48 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--dnxjz8 July 13, 2021 07:45 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--dnxjz8 July 13, 2021 17:13 Inactive
@iesahin
Copy link
Contributor Author

iesahin commented Jul 13, 2021

This draft is almost ready in scope. Could you check the structure as a UG document? @jorgeorpinel @shcheklein

I'll write a similar "Cleaning Up Experiments" before the new GS:Experiments #2574

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--dnxjz8 July 14, 2021 07:35 Inactive
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--dnxjz8 July 16, 2021 05:42 Inactive
@iesahin iesahin marked this pull request as ready for review July 16, 2021 05:44
@iesahin iesahin requested a review from jorgeorpinel July 16, 2021 05:44
@iesahin

This comment has been minimized.

@jorgeorpinel

This comment has been minimized.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-iesahin-ug-exp--dnxjz8 July 20, 2021 06:53 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-iesahin-ug-exp--dnxjz8 July 20, 2021 08:10 Inactive
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jul 20, 2021

Okdk I did a pretty major copy edit of your work @iesahin but didn't touch the story, logic, or instructions. I think this is mergeable so feel free, but I do have some comments that we can address now or as another PR later ⏳

Comment on lines 65 to 72
DVC has a mechanism called the [run-cache] that stores the artifacts from
intermediate stages. For example, if there is an intermediate step that applies
data-augmentation on your dataset and you would like to push these artifacts as
well as the end products of the experiments, you can use `--run-cache` flag to
push all of these to the DVC remote. `--run-cache` flag pushes all artifacts
referenced in `dvc.lock` file.

[run-cache]: /doc/user-guide/project-structure/internal-files#run-cache
Copy link
Contributor

@jorgeorpinel jorgeorpinel Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's what the run-cache does here. Intermediate artifacts of the experiment should be moved by exp push/pull. The run-cache probably only exists here as an edge case when you use run/repro in between exp runs. If so, no nee to even mention it probably.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. This is the only sort of major thing I would prefer to address before merge.

Copy link
Contributor

@jorgeorpinel jorgeorpinel Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and if we need to keep this part about the run-cache, what about pull --run-cache? It's not mentioned in that section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frankly I didn't test --run-cache option and this is what I got from the Ref. Need to test this I believe.

Copy link
Contributor

@jorgeorpinel jorgeorpinel Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed for now. Well, I left a small note.

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--dnxjz8 July 20, 2021 17:00 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-iesahin-ug-exp--dnxjz8 July 21, 2021 06:23 Inactive
example about cloning individual experiments
per #2618 (review)
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-iesahin-ug-exp--dnxjz8 July 21, 2021 06:33 Inactive
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jul 21, 2021

@iesahin thanks for the updates. I did another round too. I think this can be merged (feel free) but there are some pending discussions ☝️ we can address separately if you prefer. Up to you — if there's no rush to merge let's keep iterating.

@iesahin iesahin merged commit a36bbaf into master Aug 4, 2021
@iesahin iesahin mentioned this pull request Aug 4, 2021
7 tasks
@jorgeorpinel jorgeorpinel mentioned this pull request Aug 4, 2021
7 tasks
@casperdcl casperdcl deleted the iesahin/ug-exp-sharing-2367 branch August 4, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

guide: Sharing Experiments
3 participants