Simplify permission check in x/validators #527
Assignees
Comments
husio
added a commit
that referenced
this issue
May 8, 2019
- remove controller and authenticate directly in the handler - implement a custom bucket type instead of using orm.Bucket and helper functions - remove custom errors and use those declared in errors package instead - wrap all returned errors and provide additional description resolve #527
husio
added a commit
that referenced
this issue
May 8, 2019
- remove controller and authenticate directly in the handler - implement a custom bucket type instead of using orm.Bucket and helper functions - remove custom errors and use those declared in errors package instead - wrap all returned errors and provide additional description resolve #527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current implementation of permission check in
x/validatorsis very indirect and hard to track down.To undestand permissions check this chain must be followed
1 -> 2 -> 3 -> 4 -> 5 -> 6
I believe this whole chain of indirection can be reduced to a single line in which we directly ensure permissions using
authinstance.This is how we check permission everywhere, so I believe there is no reason to not code this logic into the application.
The text was updated successfully, but these errors were encountered: