Easter Egg Hunt 🐰🥚

[ethanfrey]

Let's take the time to go through the repo and hunt down the funny smells of rotten eggs. I'm sure some of this code needs some freshening. Imagine you were auditing this codebase... what parts would make you uneasy.

(The number of TODOs, particularly in app and store is a good place to start)

Let's go through the packages and create a cleanup issue for anything you find fishy (one per package, can break them down later). Maybe it is all fine. After checking it, tick it off the list and put your name on the right side. (Someone can double-check if they really want to).

• global Resolve all TODO comments #532
• weave @ruseinov Change Check and Deliver notations #480 weave package improvements #492
• app
• cmd/bcpd
• cmd/bnsd
• coin Add coin.Coin.String method #475
• commands/server @ruseinov
• crypto @ruseinov
• errors @ruseinov errors package improvements #494 Update error names #513 Implement multierror #529
• gconf Clean up gconf implementation #456
• orm Extend bucket API #536
• store @ruseinov store package improvements #521
• store/iavl
• tmtest @ruseinov
• weavetest
• x
• x/batch @ruseinov
• x/cash
• x/currency
• x/distribution
• x/escrow
• x/hashlock @ruseinov x/hashlock package improvements #514
• x/msgfee
• x/multisig
• x/namecoin
• x/nft @ruseinov
• x/nft/base @ruseinov x/nft/base package improvements #515 Cleanup x/nft handlers #533
• x/paychan Refactor payment channel timeout #481
• x/sigs
• x/utils @ruseinov x/utils package improvements #519
• x/validators @ruseinov x/validators package improvementes #485 Simplify permission check in x/validators #527

[ethanfrey]

Also nice to add a doc.go file in each package missing one when you go through it (can make mini-prs)

[husio]

Done.