Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): fix simapp simulation method update->delete (backport #4421) #4422

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 22, 2024

In simapp template, I found one mistake that uses MsgUpdateXXX where it should use MsgDeleteXXX


This is an automatic backport of pull request #4421 done by Mergify.

(cherry picked from commit da55a09)

# Conflicts:
#	ignite/templates/typed/list/files/simapp/x/{{moduleName}}/simulation/{{typeName}}.go.plush
Copy link
Contributor Author

mergify bot commented Nov 22, 2024

Cherry-pick of da55a09 has failed:

On branch mergify/bp/release/v28.x.y/pr-4421
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit da55a095.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ignite/templates/typed/list/files/simapp/x/{{moduleName}}/simulation/{{typeName}}.go.plush

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from julienrbrt as a code owner November 22, 2024 08:52
@julienrbrt julienrbrt merged commit 363912c into release/v28.x.y Nov 22, 2024
40 of 43 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4421 branch November 22, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants