fix(templates): fix simapp simulation method update->delete #4421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimurayu45z
requested review from
ilgooz,
jeronimoalbi,
Pantani and
julienrbrt
as code owners
github-actions
bot
added
component:ci
|
Great catch! Thank you |
julienrbrt
approved these changes
Nov 22, 2024
julienrbrt
added
backport/v28.x.y
julienrbrt
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
(cherry picked from commit da55a09) # Conflicts: # ignite/templates/typed/list/files/simapp/x/{{moduleName}}/simulation/{{typeName}}.go.plush
julienrbrt
added a commit
that referenced
this pull request
Nov 22, 2024
…4421) (#4422) * fix(templates): fix simapp simulation method update->delete (#4421) (cherry picked from commit da55a09) # Conflicts: # ignite/templates/typed/list/files/simapp/x/{{moduleName}}/simulation/{{typeName}}.go.plush * conflicts --------- Co-authored-by: KIMURA Yu <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In simapp template, I found one mistake that uses MsgUpdateXXX where it should use MsgDeleteXXX