feat: add flags to the extension hooks commands (backport #4270)

changelog.md

@@ -8,6 +8,7 @@
 
 - [#4262](https://github.com/ignite/cli/pull/4262) Bring back relayer command
 - [#4269](https://github.com/ignite/cli/pull/4269) Add custom flag parser for extensions
+- [#4270](https://github.com/ignite/cli/pull/4270) Add flags to the extension hooks commands
 
 ## [`v28.5.0`](https://github.com/ignite/cli/releases/tag/v28.5.0)
 

ignite/cmd/plugin.go

@@ -180,6 +180,7 @@ func linkPluginHook(rootCmd *cobra.Command, p *plugin.Plugin, hook *plugin.Hook)
 	}
 
 	newExecutedHook := func(hook *plugin.Hook, cmd *cobra.Command, args []string) *plugin.ExecutedHook {
+		hook.ImportFlags(cmd)
 		execHook := &plugin.ExecutedHook{
 			Hook: hook,
 			ExecutedCommand: &plugin.ExecutedCommand{
@@ -188,12 +189,27 @@ func linkPluginHook(rootCmd *cobra.Command, p *plugin.Plugin, hook *plugin.Hook)
 				Args:   args,
 				OsArgs: os.Args,
 				With:   p.With,
+				Flags:  hook.Flags,
 			},
 		}
 		execHook.ExecutedCommand.ImportFlags(cmd)
 		return execHook
 	}
 
+	for _, f := range hook.Flags {
+		var fs *flag.FlagSet
+		if f.Persistent {
+			fs = cmd.PersistentFlags()
+		} else {
+			fs = cmd.Flags()
+		}
+
+		if err := f.ExportToFlagSet(fs); err != nil {
+			p.Error = errors.Errorf("can't attach hook flags %q to command %q", hook.Flags, hook.PlaceHookOn)
+			return
+		}
+	}
+
 	preRun := cmd.PreRunE
 	cmd.PreRunE = func(cmd *cobra.Command, args []string) error {
 		if preRun != nil {
@@ -218,11 +234,10 @@ func linkPluginHook(rootCmd *cobra.Command, p *plugin.Plugin, hook *plugin.Hook)
 	}
 
 	runCmd := cmd.RunE
-
 	cmd.RunE = func(cmd *cobra.Command, args []string) error {
 		if runCmd != nil {
 			err := runCmd(cmd, args)
-			// if the command has failed the `PostRun` will not execute. here we execute the cleanup step before returnning.
+			// if the command has failed the `PostRun` will not execute. here we execute the cleanup step before returning.
 			if err != nil {
 				api, err := newAppClientAPI(cmd)
 				if err != nil {

ignite/services/plugin/grpc/v1/interface_command.go

@@ -32,7 +32,7 @@ func (c *Command) ToCobraCommand() (*cobra.Command, error) {
 			fs = cmd.Flags()
 		}
 
-		if err := f.exportToFlagSet(fs); err != nil {
+		if err := f.ExportToFlagSet(fs); err != nil {
 			return nil, err
 		}
 	}
@@ -54,7 +54,7 @@ func (c *ExecutedCommand) NewFlags() (*pflag.FlagSet, error) {
 			continue
 		}
 
-		if err := f.exportToFlagSet(fs); err != nil {
+		if err := f.ExportToFlagSet(fs); err != nil {
 			return nil, err
 		}
 	}
@@ -71,7 +71,7 @@ func (c *ExecutedCommand) NewPersistentFlags() (*pflag.FlagSet, error) {
 			continue
 		}
 
-		if err := f.exportToFlagSet(fs); err != nil {
+		if err := f.ExportToFlagSet(fs); err != nil {
 			return nil, err
 		}
 	}

ignite/services/plugin/grpc/v1/interface_flag.go

@@ -33,7 +33,7 @@ func newDefaultFlagValueError(typeName, value string) error {
 	return errors.Errorf("invalid default value for plugin command %s flag: %s", typeName, value)
 }
 
-func (f *Flag) exportToFlagSet(fs *pflag.FlagSet) error {
+func (f *Flag) ExportToFlagSet(fs *pflag.FlagSet) error {
 	switch f.Type { //nolint:exhaustive
 	case Flag_TYPE_FLAG_BOOL,
 		Flag_TYPE_FLAG_INT,

ignite/services/plugin/grpc/v1/interface_hook.go

@@ -1,6 +1,13 @@
 package v1
 
+import "github.com/spf13/cobra"
+
 // CommandPath returns the absolute command path including the binary name as prefix.
 func (h *Hook) CommandPath() string {
 	return ensureFullCommandPath(h.PlaceHookOn)
 }
+
+// ImportFlags imports flags from a Cobra command.
+func (h *Hook) ImportFlags(cmd *cobra.Command) {
+	h.Flags = extractCobraFlags(cmd)
+}