Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flags to the extension hooks commands (backport #4270) #4280

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 25, 2024

close ignite/apps#118

Description

This PR adds the ability to extend the command flags using extension hooks and also passes the flags to the hook interface to be accessible into the extension.


This is an automatic backport of pull request #4270 done by Mergify.

* add flags to the hook commands

* add flags to executed hook cmd

* create hook.ImportFlags method

* add changelog

* Update changelog.md

(cherry picked from commit 54e7f52)

# Conflicts:
#	ignite/services/plugin/grpc/v1/interface.pb.go
Copy link
Contributor Author

mergify bot commented Jul 25, 2024

Cherry-pick of 54e7f52 has failed:

On branch mergify/bp/release/v28.x.y/pr-4270
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 54e7f526.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   ignite/cmd/plugin.go
	modified:   ignite/services/plugin/grpc/v1/client_api.pb.go
	modified:   ignite/services/plugin/grpc/v1/interface_command.go
	modified:   ignite/services/plugin/grpc/v1/interface_flag.go
	modified:   ignite/services/plugin/grpc/v1/interface_hook.go
	modified:   ignite/services/plugin/grpc/v1/service.pb.go
	modified:   ignite/services/plugin/grpc/v1/service_grpc.pb.go
	modified:   proto/ignite/services/plugin/grpc/v1/interface.proto

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ignite/services/plugin/grpc/v1/interface.pb.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from julienrbrt as a code owner July 25, 2024 21:22
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd type:services Service-related issues. labels Jul 25, 2024
@julienrbrt julienrbrt enabled auto-merge (squash) July 26, 2024 13:57
@julienrbrt julienrbrt merged commit 04dbd45 into release/v28.x.y Jul 29, 2024
45 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4270 branch July 29, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs conflicts type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants