Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate plugins.yml file #3184

Merged
merged 44 commits into from
Nov 30, 2022
Merged

feat: separate plugins.yml file #3184

merged 44 commits into from
Nov 30, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Nov 28, 2022

Closes #3152

Will follow this up with the global config

@aljo242 aljo242 requested a review from tbruyelle as a code owner November 28, 2022 21:24
ignite/cmd/plugin.go Outdated Show resolved Hide resolved
ignite/cmd/cmd.go Outdated Show resolved Hide resolved
jeronimoalbi
jeronimoalbi previously approved these changes Nov 29, 2022
ignite/cmd/plugin.go Outdated Show resolved Hide resolved
@aljo242 aljo242 merged commit 1317723 into main Nov 30, 2022
@aljo242 aljo242 deleted the feat/separate-plugins-config branch November 30, 2022 14:44
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* base

* base refactor

* refactor

* rename

* rename

* fix comment

* rename file

* format

* refactor base

* format

* refactor some imports

* imports refactor

* fix

* fix import

* refactor:

* changelog

* changelog

* Update ignite/services/network/networkchain/init.go

Co-authored-by: Jerónimo Albi <[email protected]>

* base -> baseconfig

* refactoring for clarity

* v12 -> v1

* fix tests

* fix integration

* fix name

* fix integration

* format

* Update ignite/cmd/cmd.go

Co-authored-by: Jerónimo Albi <[email protected]>

* imports

* LocateDefault logic

* lint fix

* refactor and test

* finish refactor

* revert

* address review

* testdata

Co-authored-by: Jerónimo Albi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move config migration to be done before loading plugins
3 participants