Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remove plugin commands #3181

Merged
merged 42 commits into from
Dec 6, 2022
Merged

feat: add remove plugin commands #3181

merged 42 commits into from
Dec 6, 2022

Conversation

joshLong145
Copy link
Contributor

@joshLong145 joshLong145 commented Nov 27, 2022

  • addition of plugin add <path> [args]
  • addition of plugin remove <path>

connects #3131

@joshLong145 joshLong145 changed the title feat: add-remove commands feat: add remove plugin commands Nov 27, 2022
@joshLong145 joshLong145 linked an issue Nov 27, 2022 that may be closed by this pull request
@aljo242 aljo242 changed the title feat: add remove plugin commands feat: add remove plugin commands Nov 28, 2022
@aljo242 aljo242 changed the title feat: add remove plugin commands feat: add remove plugin commands Nov 28, 2022
@joshLong145
Copy link
Contributor Author

@tbruyelle @aljo242 should we add the ability to specify key value pairs to hydrate With plugin options. was thinking it would turn the add command to ignite plugin add <path> [args]

@joshLong145 joshLong145 marked this pull request as ready for review November 29, 2022 20:08
@joshLong145 joshLong145 added the component:extensions Related to Ignite Extensions. label Nov 29, 2022
@aljo242
Copy link
Contributor

aljo242 commented Nov 30, 2022

@tbruyelle @aljo242 should we add the ability to specify key value pairs to hydrate With plugin options. was thinking it would turn the add command to ignite plugin add <path> [args]

Yes, this makes sense to me. As long as the default behavior (no args) is simple.

@tbruyelle
Copy link
Contributor

@tbruyelle @aljo242 should we add the ability to specify key value pairs to hydrate With plugin options. was thinking it would turn the add command to ignite plugin add <path> [args]

Excellent idea, that will give the opportunity for plugin developers to provide a unique command to install their plugin in case there's configuration options.

ignite/cmd/plugin.go Outdated Show resolved Hide resolved
ignite/cmd/plugin.go Outdated Show resolved Hide resolved
ignite/cmd/plugin.go Outdated Show resolved Hide resolved
ignite/cmd/plugin.go Outdated Show resolved Hide resolved
@joshLong145 joshLong145 requested a review from tbruyelle December 1, 2022 19:43
@joshLong145 joshLong145 requested a review from Pantani as a code owner December 1, 2022 20:35
tbruyelle
tbruyelle previously approved these changes Dec 1, 2022
Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition @joshLong145 thank you!

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@1d25040). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3181   +/-   ##
=======================================
  Coverage        ?   19.90%           
=======================================
  Files           ?      383           
  Lines           ?    30230           
  Branches        ?        0           
=======================================
  Hits            ?     6017           
  Misses          ?    23637           
  Partials        ?      576           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aljo242 aljo242 merged commit fd3778b into main Dec 6, 2022
@aljo242 aljo242 deleted the feat/plugin-manage-cmds branch December 6, 2022 20:10
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* add-remove commands

* removing of load from remove plugin cmd

* changelog update

* typo fix

* formatting and lint run

* update cmd output

* fix to imports and control flow

* updates for plugin config migration

* fmt fixes

* scoping save implementation to plugin config

* fix to control flow

* comment update

* addition of LoadSingle for plugin service

* removal of loading flag for default add behavior

* updates to config persist

* update to plugin config parsing

* updates per review comments

* simplication of plugin config path resolving

* update to comments

* fix changelog formatting

* update to command help info

* removal of omittion of plugin erray on serialization

* fmt

* doc fixes

* addition of argument parse for plugin add

* fix

Co-authored-by: Alex Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:extensions Related to Ignite Extensions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a plugin from command line
3 participants