-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add
remove
plugin commands
#3181
Conversation
remove plugin
commands
remove plugin
commandsadd
remove
plugin commands
@tbruyelle @aljo242 should we add the ability to specify key value pairs to hydrate |
Yes, this makes sense to me. As long as the default behavior (no args) is simple. |
Excellent idea, that will give the opportunity for plugin developers to provide a unique command to install their plugin in case there's configuration options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition @joshLong145 thank you!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3181 +/- ##
=======================================
Coverage ? 19.90%
=======================================
Files ? 383
Lines ? 30230
Branches ? 0
=======================================
Hits ? 6017
Misses ? 23637
Partials ? 576 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
* add-remove commands * removing of load from remove plugin cmd * changelog update * typo fix * formatting and lint run * update cmd output * fix to imports and control flow * updates for plugin config migration * fmt fixes * scoping save implementation to plugin config * fix to control flow * comment update * addition of LoadSingle for plugin service * removal of loading flag for default add behavior * updates to config persist * update to plugin config parsing * updates per review comments * simplication of plugin config path resolving * update to comments * fix changelog formatting * update to command help info * removal of omittion of plugin erray on serialization * fmt * doc fixes * addition of argument parse for plugin add * fix Co-authored-by: Alex Johnson <[email protected]>
plugin add <path> [args]
plugin remove <path>
connects #3131