feat(config): global plugins config
#3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jerónimo Albi <[email protected]>
tbruyelle
reviewed
Dec 13, 2022
tbruyelle
reviewed
Dec 13, 2022
tbruyelle
reviewed
Dec 13, 2022
tbruyelle
reviewed
Dec 13, 2022
tbruyelle
reviewed
Dec 13, 2022
Co-authored-by: Thomas Bruyelle <[email protected]>
tbruyelle
reviewed
Dec 13, 2022
Co-authored-by: Thomas Bruyelle <[email protected]>
|
@aljo242 I added a last commit to test |
tbruyelle
previously approved these changes
Dec 13, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3214 +/- ##
==========================================
- Coverage 20.06% 20.05% -0.02%
==========================================
Files 385 384 -1
Lines 30845 30935 +90
==========================================
+ Hits 6190 6203 +13
- Misses 24067 24141 +74
- Partials 588 591 +3
|
jeronimoalbi
approved these changes
Dec 14, 2022
tbruyelle
approved these changes
Dec 14, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* base * base refactor * refactor * rename * rename * fix comment * rename file * format * refactor base * format * refactor some imports * imports refactor * fix * fix import * refactor: * changelog * changelog * Update ignite/services/network/networkchain/init.go Co-authored-by: Jerónimo Albi <[email protected]> * base -> baseconfig * refactoring for clarity * v12 -> v1 * fix tests * fix integration * fix name * fix integration * format * Update ignite/cmd/cmd.go Co-authored-by: Jerónimo Albi <[email protected]> * imports * LocateDefault logic * lint fix * refactor and test * finish refactor * revert * move * move * rename * fix tests * fix test * rename * add global * functionality * format * fix error statement for global plugins * typo * chainconfig * imports * fix imports * address review * testdata * better import * fix test * changelog * refactor * simplify * RemoveDuplicates * refactor LoadPlugins * lint * add global flag * add info * add error prints * simplify return * fix test * fix global parse * add integration test * modify test * fix returns * use ignite example plugin * refactor global flag * Fix plugin integration test Add more assertion and use an alternate `.ignite` folder to avoid conflicts with user home. Also fix `plugin add -g` when `.ignite/plugins` doesn't exist. * add removed TODO by mistake * move flags * return err * Update ignite/cmd/plugin.go Co-authored-by: Thomas Bruyelle <[email protected]> * format * fix test * remove yaml tag * Update ignite/cmd/plugin.go Co-authored-by: Thomas Bruyelle <[email protected]> * fix test * test: add key/value pairs to plugin add * add detailed plugin Co-authored-by: Jerónimo Albi <[email protected]> Co-authored-by: Thomas Bruyelle <[email protected]> Co-authored-by: Thomas Bruyelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3132
Closes #3279
Adds the global flag: