Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ICA controller wiring #2884

Merged
merged 1 commit into from
Oct 5, 2022
Merged

fix: ICA controller wiring #2884

merged 1 commit into from
Oct 5, 2022

Conversation

tbruyelle
Copy link
Contributor

Fix #2867

Found how the wiring is done in gaia 👼

I wasn't sure if I should add a new field in the App struct for this keeper, so I didn't, tell me if I should.

Now the incriminated command in the issue works :

$ appd query ica controller params
controller_enabled: true

Copy link
Member

@jeronimoalbi jeronimoalbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

It works now.

@aljo242 aljo242 merged commit b08039f into develop Oct 5, 2022
@aljo242 aljo242 deleted the fix/ica-controller-wiring branch October 5, 2022 12:31
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICA controller keeper is not wired
3 participants