Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICA controller keeper is not wired #2867

Closed
tbruyelle opened this issue Sep 29, 2022 · 1 comment · Fixed by #2884
Closed

ICA controller keeper is not wired #2867

tbruyelle opened this issue Sep 29, 2022 · 1 comment · Fixed by #2884
Labels
type:bug Something isn't working

Comments

@tbruyelle
Copy link
Contributor 

appd query ica controller params
Error: rpc error: code = Unknown desc = value method github.com/cosmos/ibc-go/v5/modules/apps/27-interchain-accounts/controller/keeper.Keeper.Params called using nil *Keeper pointer: panic

We need to replace the nil with the ica controller keeper.
https://github.com/ignite/cli/blob/develop/ignite/templates/app/stargate/app/app.go.plush#L450
@tbruyelle tbruyelle added type:bug Something isn't working report labels Sep 29, 2022
@tbruyelle tbruyelle mentioned this issue Sep 29, 2022
Closed
@RaulBernal
Copy link
Contributor

Thanks 😊

@tbruyelle tbruyelle removed the report label Oct 4, 2022
tbruyelle added a commit that referenced this issue Oct 5, 2022
@tbruyelle
fix: ICA controller wiring
83c9f06 
Fix #2867
@tbruyelle tbruyelle mentioned this issue Oct 5, 2022
Merged
aljo242 pushed a commit that referenced this issue Oct 5, 2022
@tbruyelle
fix: ICA controller wiring (#2884)
b08039f 
Fix #2867
@tbruyelle tbruyelle mentioned this issue Nov 2, 2022
Merged
tbruyelle added a commit that referenced this issue Nov 2, 2022
@tbruyelle
docs: add migration guide for #2867
94459d3
aljo242 pushed a commit that referenced this issue Nov 2, 2022
@tbruyelle @jeronimoalbi
docs: cosmoscmd migration (#2949)
6686bb6 
* start guide

* remaining changes

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* highlight and update version

* add highlight magic comments

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Jerónimo Albi <[email protected]>

* rename

* address feedback

* add custom docusaurus magic-comment to highlight removed lines

* remaining fixes

* docs: broader usage of remove-next-line magic comment

* docs: add migration guide for #2867

* docs: add migration guide for #1921

* docs: remove proto migration from v0.25.1

since it's already present in migration v0.25.0

* docs: Dragonberry fix migration

Also:
- reorg migration guides between v0.25.1 and v0.25.0
- fix broken yaml in markdown headers

* docs: format

Co-authored-by: Thomas Bruyelle <[email protected]>
Co-authored-by: Jerónimo Albi <[email protected]>
Co-authored-by: Thomas Bruyelle <[email protected]>
Jchicode pushed a commit to Jchicode/cli that referenced this issue Aug 9, 2023
@tbruyelle
fix: ICA controller wiring (ignite#2884)
f6b723e 
Fix ignite#2867
Jchicode pushed a commit to Jchicode/cli that referenced this issue Aug 9, 2023
@tbruyelle @jeronimoalbi
docs: cosmoscmd migration (ignite#2949)
45cacd5 
* start guide

* remaining changes

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Thomas Bruyelle <[email protected]>

* highlight and update version

* add highlight magic comments

* Update docs/docs/migration/v0.25.0.md

Co-authored-by: Jerónimo Albi <[email protected]>

* rename

* address feedback

* add custom docusaurus magic-comment to highlight removed lines

* remaining fixes

* docs: broader usage of remove-next-line magic comment

* docs: add migration guide for ignite#2867

* docs: add migration guide for ignite#1921

* docs: remove proto migration from v0.25.1

since it's already present in migration v0.25.0

* docs: Dragonberry fix migration

Also:
- reorg migration guides between v0.25.1 and v0.25.0
- fix broken yaml in markdown headers

* docs: format

Co-authored-by: Thomas Bruyelle <[email protected]>
Co-authored-by: Jerónimo Albi <[email protected]>
Co-authored-by: Thomas Bruyelle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ICA controller wiring ignite/cli
2 participants
@tbruyelle @RaulBernal