Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restored deleted test line #182

Merged
merged 6 commits into from
Aug 22, 2019
Merged

restored deleted test line #182

merged 6 commits into from
Aug 22, 2019

Conversation

RaniAbboud
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 22, 2019

Coverage Status

Coverage remained the same at 83.403% when pulling 693e986 on logout_wrapper into 6738e67 on development.

@RaniAbboud RaniAbboud requested a review from rotembr August 22, 2019 15:12
@RaniAbboud
Copy link
Contributor Author

I hope I fixed the the test

@RaniAbboud RaniAbboud merged commit c3822f9 into development Aug 22, 2019
@RaniAbboud RaniAbboud deleted the logout_wrapper branch August 22, 2019 15:27
rotembr pushed a commit that referenced this pull request Aug 23, 2019
* update login widget section in readme

* changing initializer to public (#171)

* Point to v4 (#173)

* Update to point to v4 + iss and aud validation
 Adds azp and issuer validation for V4

* Issue 2439 (#174)

Removed azp validation and updated tokens to v4 for tests

* bump up version to 6.0.0

* Issue 3201 (#177)

* update depandencies and fix warnings

* bump up version

* update xcode version

* added a logout function in AppID class which wraps AppIDAuthorizationManager's logout.

* added an example on logout in readme

* deleted empty line

* disabled a line in testRegisterOAuthClient2 where the test failed on an assertion because of a difference in map order

* added slack link

* restored deleted test line (#182)


* fixed test testRegisterOAuthClient2, it was failing because of map elements' order
rotembr added a commit that referenced this pull request Aug 23, 2019
* update login widget section in readme

* changing initializer to public (#171)

* Point to v4 (#173)

* Update to point to v4 + iss and aud validation
 Adds azp and issuer validation for V4

* Issue 2439 (#174)

Removed azp validation and updated tokens to v4 for tests

* bump up version to 6.0.0

* Issue 3201 (#177)

* update depandencies and fix warnings

* bump up version

* update xcode version

* added a logout function in AppID class which wraps AppIDAuthorizationManager's logout.

* added an example on logout in readme

* deleted empty line

* disabled a line in testRegisterOAuthClient2 where the test failed on an assertion because of a difference in map order

* added slack link

* restored deleted test line (#182)


* fixed test testRegisterOAuthClient2, it was failing because of map elements' order

* added some description to logout

* update version to 6.0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants