changing initializer to public #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Master -> Development (Rebranding)
Update IBMCloudAppID.podspec
gtaban
approved these changes
Feb 12, 2019
gtaban
added a commit
that referenced
this pull request
Feb 13, 2019
* update login widget section in readme * changing initializer to public (#171)
rotembr
pushed a commit
that referenced
this pull request
Jul 7, 2019
* update login widget section in readme * changing initializer to public (#171) * Point to v4 (#173) * Update to point to v4 + iss and aud validation Adds azp and issuer validation for V4 * Issue 2439 (#174) Removed azp validation and updated tokens to v4 for tests * bump up version to 6.0.0 * Issue 3201 (#177) * update depandencies and fix warnings * bump up version * update xcode version
rotembr
pushed a commit
that referenced
this pull request
Aug 23, 2019
* update login widget section in readme * changing initializer to public (#171) * Point to v4 (#173) * Update to point to v4 + iss and aud validation Adds azp and issuer validation for V4 * Issue 2439 (#174) Removed azp validation and updated tokens to v4 for tests * bump up version to 6.0.0 * Issue 3201 (#177) * update depandencies and fix warnings * bump up version * update xcode version * added a logout function in AppID class which wraps AppIDAuthorizationManager's logout. * added an example on logout in readme * deleted empty line * disabled a line in testRegisterOAuthClient2 where the test failed on an assertion because of a difference in map order * added slack link * restored deleted test line (#182) * fixed test testRegisterOAuthClient2, it was failing because of map elements' order
rotembr
added a commit
that referenced
this pull request
Aug 23, 2019
* update login widget section in readme * changing initializer to public (#171) * Point to v4 (#173) * Update to point to v4 + iss and aud validation Adds azp and issuer validation for V4 * Issue 2439 (#174) Removed azp validation and updated tokens to v4 for tests * bump up version to 6.0.0 * Issue 3201 (#177) * update depandencies and fix warnings * bump up version * update xcode version * added a logout function in AppID class which wraps AppIDAuthorizationManager's logout. * added an example on logout in readme * deleted empty line * disabled a line in testRegisterOAuthClient2 where the test failed on an assertion because of a difference in map order * added slack link * restored deleted test line (#182) * fixed test testRegisterOAuthClient2, it was failing because of map elements' order * added some description to logout * update version to 6.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having the initializer public, multiple App ID instances can be instantiated.
https://github.ibm.com/security-services/appid-project-management/issues/2315