Use jstranform instead of recast (massive speedup) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gains us a massive speedup, envify w/ recast takes almost 7 secs on my mba when browserifying React codebase. While envify w/ jstransform takes this down to 1.5 sec (pre-recast speed) and deliver the same advantages as recast transform (preserves code formatting).
|
See referenced React issue for numbers. |
|
cc @benjamn |
|
I agree that |
|
@andreypopp that's an impressive speed boost, thanks for this! Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gains us a massive speedup, envify w/ recast takes almost 7 secs on my MBA
when browserifying React codebase. While envify w/ jstransform brings this down
to 1.5 sec (pre-recast speed) and delivers the same advantages as recast
transform (preserves code formatting).