Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browserify -r react takes almost 7 seconds #1108

Closed
andreypopp opened this issue Feb 17, 2014 · 1 comment · Fixed by #1117
Closed

Browserify -r react takes almost 7 seconds #1108

andreypopp opened this issue Feb 17, 2014 · 1 comment · Fixed by #1117

Comments

@andreypopp
Copy link
Contributor

React 0.8

% time browserify -r react > /dev/null
browserify -r react > /dev/null  1.67s user 0.15s system 103% cpu 1.759 total

React 0.9

wmbp % time browserify -r react > /dev/null            ~/Workspace/test/react09
browserify -r react > /dev/null  6.97s user 0.25s system 101% cpu 7.091 total

I think this is because of envify switched to recast in 1.0.0. I submitted a patch to envify which uses jstransform instead of recast.

This brings us back to 1.5s and delivers the same advantages as recast version (preserves code formatting):

wmbp % time browserify -r react > /dev/null
browserify -r react > /dev/null  1.52s user 0.16s system 104% cpu 1.602 total

I think this is blocker for 0.9.0.

@benjamn
Copy link
Contributor

benjamn commented Feb 17, 2014

What command are you running, and in what directory? I'm having trouble reproducing the slow-down with just browserify -r react.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants