-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added dynamic feeAmount parameter to fungible and non-fungible token create with custom fee method #700
Conversation
…thod Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
} else if (withCustomFee && Number(feeTokenAmount) <= 0) { | ||
sanitizeErr = 'Custom fee amount must be positive'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if applicable, should we also validate if the number if too big?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice input! Though I think we can address it in another PR.
@@ -73,7 +75,8 @@ export const createHederaFungibleToken = async ( | |||
treasury: string, | |||
inputKeys: ICommonKeyObject[], | |||
msgValue: string, | |||
feeTokenAddress?: string | |||
feeTokenAddress?: string, | |||
feeTokenAmount?: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, should we use feeAmount
to be consistent with the rest of the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha I don't know why I left it as feeTokenAmount! Good catch thanks! Pushed in the fix!
Signed-off-by: Logan Nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description:
Related issue(s):
Fixes #329
UI updates:
Notes for reviewer:
Checklist