Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In TokenCreateCustom contract, the IHederaTokenService.FixedFee can be set to accept dynamic params #329

Closed
quiet-node opened this issue Aug 14, 2023 · 0 comments · Fixed by #700
Assignees
Labels
enhancement New feature or request

Comments

@quiet-node
Copy link
Member

quiet-node commented Aug 14, 2023

Problem

Currently in createFungibleTokenWithCustomFeesPublic and createNonFungibleTokenWithCustomFeesPublic, the fixed fee is constructed in a way that accepts 1 for the amount as default.

fixedFees[0] = IHederaTokenService.FixedFee(1, fixedFeeTokenAddress, false, false, treasury);

This can be updated so that IHederaTokenService.FixedFee can accepts dynamic values from the parameters.

Solution

Add an uint256 feeAmount param to the parameter list then replaced

fixedFees[0] = IHederaTokenService.FixedFee(1, fixedFeeTokenAddress, false, false, treasury);

with

fixedFees[0] = IHederaTokenService.FixedFee(feeAmount, fixedFeeTokenAddress, false, false, treasury);

Alternatives

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
1 participant