Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FileReadableKVState #9570

Merged
merged 14 commits into from
Oct 15, 2024
Merged

Add FileReadableKVState #9570

merged 14 commits into from
Oct 15, 2024

Conversation

kselveliev
Copy link
Contributor

Description:
This pr add FileReadableKVState

Related issue(s):

Fixes #9258

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@kselveliev
feat: Add FileReadableKVState
e788619 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev kselveliev self-assigned this Oct 11, 2024
@kselveliev kselveliev added web3 Area: Web3 API enhancement Type: New feature labels Oct 11, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.73381% with 24 lines in your changes missing coverage. Please review.

Project coverage is 92.22%. Comparing base (bddd711) to head (ef2b66c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ain/java/com/hedera/hapi/node/state/file/File.java 78.94% 4 Missing and 20 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #9570      +/-   ##
============================================
- Coverage     92.26%   92.22%   -0.05%     
- Complexity     7468     7515      +47     
============================================
  Files           927      929       +2     
  Lines         31167    31306     +139     
  Branches       3978     4001      +23     
============================================
+ Hits          28756    28871     +115     
- Misses         1492     1496       +4     
- Partials        919      939      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kselveliev
fix: Fix code smells
eedcc80 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev
fix: Addressing review comments
a505fb1 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev
fix: Addressing review comments
9afeed2 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev
fix: Addressing review comments
2d8a5c8 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev kselveliev marked this pull request as ready for review October 14, 2024 13:59
@kselveliev
fix: Addressing review comments
d2b7562 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev
fix: Addressing review comments
63dc842 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev
fix: Addressing review comment
3ef3e37 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev
fix: Increase codecoverage
5d5578a 
Signed-off-by: Kristiyan Selveliev <[email protected]>
bilyana-gospodinova
bilyana-gospodinova previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IvanKavaldzhiev
IvanKavaldzhiev previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@IvanKavaldzhiev IvanKavaldzhiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kselveliev
fix: Addressing review comments
bfe7bc1 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev
fix: Addressing comment
ef2b66c 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.9% Duplication on New Code

See analysis details on SonarCloud

bilyana-gospodinova
bilyana-gospodinova approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy added this to the 0.116.0 milestone Oct 15, 2024
@steven-sheehy steven-sheehy merged commit b84532a into main Oct 15, 2024
32 of 33 checks passed
@steven-sheehy steven-sheehy deleted the 09258-file-readable-kv-state branch October 15, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilyana-gospodinova bilyana-gospodinova bilyana-gospodinova approved these changes

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@nickeynikolovv nickeynikolovv Awaiting requested review from nickeynikolovv

@IvanKavaldzhiev IvanKavaldzhiev Awaiting requested review from IvanKavaldzhiev

Assignees

@kselveliev kselveliev

Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
None yet
Milestone
0.116.0
Development

Successfully merging this pull request may close these issues.

Implement FileReadableKVState
4 participants
@kselveliev @IvanKavaldzhiev @steven-sheehy @bilyana-gospodinova