Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FileReadableKVState #9258

Closed
Tracked by #8828
IvanKavaldzhiev opened this issue Sep 3, 2024 · 0 comments · Fixed by #9570
Closed
Tracked by #8828

Implement FileReadableKVState #9258

IvanKavaldzhiev opened this issue Sep 3, 2024 · 0 comments · Fixed by #9570
Assignees
Labels
enhancement Type: New feature web3 Area: Web3 API
Milestone

Comments

@IvanKavaldzhiev
Copy link
Contributor

Problem

We need to add a new type of database accessor to read system files data, so that we have specific ReadableKVState instance for this type of data.

Solution

Add FileDatabaseAccessor class that reads system files and converts them to File PBJ type.

Add unit tests to cover all cases including historical reads and correct mapping for all fields.

Alternatives

No response

@IvanKavaldzhiev IvanKavaldzhiev added the enhancement Type: New feature label Sep 3, 2024
@IvanKavaldzhiev IvanKavaldzhiev added the web3 Area: Web3 API label Sep 3, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Mirror Node Sep 3, 2024
@steven-sheehy steven-sheehy moved this from 📋 Backlog to 🏃‍♀ Sprint backlog in Mirror Node Sep 29, 2024
@steven-sheehy steven-sheehy added this to the 0.116.0 milestone Sep 29, 2024
@steven-sheehy steven-sheehy changed the title Add FileDatabaseAccessor for reading system files Add FileReadableKVState for reading system files Sep 30, 2024
@kselveliev kselveliev self-assigned this Oct 3, 2024
@steven-sheehy steven-sheehy changed the title Add FileReadableKVState for reading system files Implement FileReadableKVState Oct 11, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Mirror Node Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants