Corrected the sign positions on the final note of liquescent salicus glyphs. #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…glyphs. This is a missing part of gregorio-project#622.
|
Anyone willing to review this? I'd like to get this into the next 4.0.0 build since it's actually a fix for a bug introduced since the previous build. |
|
I'm reviewing it right now. Just waiting for the tests to finish up. |
|
Looks good. All tests pass. |
henryso
added a commit
to gregorio-project/gregorio-test
that referenced
this pull request
Oct 9, 2015
rpspringuel
added a commit
that referenced
this pull request
Oct 9, 2015
Corrected the sign positions on the final note of liquescent salicus glyphs.
|
Thank you for the consideration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a missing part of #622.
While implementing #631, I found a bug in sign positions on last note of liquescent salicus glyphs, most noticeable with then the last note is deminutus. This should fix it.
As this is a bug-fix for an as-yet unreleased change, I am not adding to the changelog.
Please review and merge if satisfactory.