-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add titleProp option #88
Milestone
Comments
marques-kevin
added a commit
to marques-kevin/svgr
that referenced
this issue
May 22, 2018
marques-kevin
added a commit
to marques-kevin/svgr
that referenced
this issue
May 23, 2018
marques-kevin
added a commit
to marques-kevin/svgr
that referenced
this issue
May 23, 2018
marques-kevin
added a commit
to marques-kevin/svgr
that referenced
this issue
May 23, 2018
gregberge
pushed a commit
that referenced
this issue
May 24, 2018
@neoziro, instead of this can we just pass as below, this will support ARIA as well - <SvgrComponent aria-labelledby='fancy-svg-id'>
<title id='fancy-svg-id'> Title goes here </title>
</SvgrComponent> |
Yes I think it is a good idea, why not in future. |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As mentioned in #75, it would be nice to be able to specify a title using props. To do it, my proposition is to add a boolean option "titleProp" defaulting to
false
. When activated, user would be able to specify the title of the SVG using props.Usage in command line
Usage in Node / Webpack
Usage in React, when the option is activated
The text was updated successfully, but these errors were encountered: