PropTypes when adding the title

[julien51]

🚀 Feature Proposal

Having the ability to add a title prop is a very useful feature. We also use fairly strict linting rules which require us to add propTypes on any React component. It would be great when using --title-prop to have the ability to add the corresponding propType.

I understand that one could use --template for this, but since --title-prop exists, we may as well complete that feature.

Motivation

This would make the component pass when eslint-ing with strict rules.

Example

svgr --title-prop --title-prop-type string --title-defafult-prop "" would generate something like

import React from 'react'
import PropTypes from 'prop-types'

const SvgComponent = ({ title, ...props }) => (
  <svg width="1em" height="1em" viewBox="0 0 48 1" {...props}>
    <title>{title}</title>
    <path d="M0 0h48v1H0z" fill="currentColor" fillRule="evenodd" />
  </svg>
)

SvgComponent.propTypes = {
  title: PropTypes.string,
}


SvgComponent.defaultProps = {
  title: "",
}

export default SvgComponent

Pitch

It would be a good addition to the --title-prop

I am happy to try submitting a patch if this is approved!

[gregberge]

Hmm, maybe we could change the API to be able to accept children, see #88 (comment). I think it could match your need isn't it?

[gregberge]

Hello @julien51, prop-types will not be integrated in the project. If you want to use them, I suggest you to create a custom template.