Suspended tab doesn't automatically unsuspend after closing another tab

[sunspeck]

The latest update to this great extension seems to have introduced a bug / removed a desirable behavior.

I have it set to "Automatically unsuspend tab when it is viewed."

Previously, this would unsuspend tabs when they are clicked on, and also unsuspend a newly focussed tab when the previous tab is closed (via keyboard shortcut or [X] button).

The new update will no longer automatically unsuspend the next tab when a tab is closed. To unsuspend the next tab I must manually switch away from it and then switch back.

I found the original way this was handled to be much more intuitive, useful, and effective.

Thanks!

[poulhansen]

It's the same here although sometimes it works.
It happened after my screen showed an "update" to the program.
It works when clicking the tab but not after closing the previous tab, then the new tab that emerges, stays suspended.

[deanoemcke]

I have updated the issue title to be more specific as it looks like clicking on a suspended tab does automatically unsuspend it. It is only failing when a tab is closed and a suspended tab is shown in its place.

[deanoemcke]

lol. i just came across this other issue which tidying up: #114

it requests that suspended tabs that gain focus after anther tab is closed should not automatically unsuspend. i agreed with the user at the time, hence the change in functionality.
it's not a bug, it's a feature!

i guess the long-term solution is to have this as a configurable option.

[sunspeck]

Hi, I only realized after I posted this what you were already dealing with regarding the security issue, yikes.

After living with this new behavior for a few days, and turning on the screen capture function to cope with it, I can sorta see how it would be desirable at times. But a configurable option allowing auto-unsuspend after tab close would definitely be enjoyed by those of us who open a stack of tabs to read the morning news.

Anyway, many thanks for this fine plugin which has saved my Macbook from a most certain heat death.

[acidlung]

I agree with sunspeck that the previous behavior (automatically unsuspending focused tabs rather than forcing a click) was more intuitive. Since I usually have 20 tabs open and am doing research, when I revert to a suspended tab, I almost always want to view it. Admittedly, that is MY personal workflow and my style is probably in the minority. That said, I'm the type of user that realizes huge benefits from your excellent extension and doesn't mind diving into the settings screen to really dial things in. Others obviously have a different use case.
I enthusiastically agree that making this behavior into a setting would be hugely helpful for me and make all parties happy. Also it should likely default to the current behavior since users seem to prefer it, judging by the fact that only a few have filed an issue since you changed it.

[smilejack1]

My work habits are like acidlung's, and would greatly prefer either a reversion to the previous behavior or to have such behavior as an option. As much as I appreciate this extension, it is much less helpful to me than it was.

[deanoemcke]

After some deliberation, I have decided to revert this functionality back to how it used to be. Any suspended tab that gains focus will now automatically reload, regardless of whether the focus was gained via the closing of another tab.
The main reason for this decision was consistency. It appeared to be too much like a bug the way it currently operated. And I'm not sure the number of people in favour or against this feature is significant either way.

[poulhansen]

THANK YOU for your time. Poul Hansen May you enjoy Peace and Happiness! Give time, the most precious gift. Make the world better, stop Anger and Greed

…

On 18 August 2017 at 16:26, Dean Oemcke ***@***.***> wrote: After some deliberation, I have decided to revert this functionality back to how it used to be. Any suspended tab that gains focus will now automatically reload, regardless of whether the focus was gained via the closing of another tab. The main reason for this decision was consistency. It appeared to be too much like a bug the way it currently operated. And I'm not sure the number of people in favour or against this feature is significant either way. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#519 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ab6pfGyPm5RWDYvzTFsIqCcFhB1HjdHMks5sZZ8agaJpZM4NyNxF> .

[draarong]

@deanoemcke I'm really glad you decided that a tab gaining focus after another tab is closed should be automatically unsuspended...But it doesn't seem to work for me! Has something changed w/more recent versions of MacOS or Chrome?

[mcmasjc3]

I never have seen it work. I figured Dean changed his mind. Jim McMaster mailto:[email protected]

…

On Fri, May 11, 2018 at 5:35 PM, draarong ***@***.***> wrote: @deanoemcke <https://github.com/deanoemcke> I'm really glad you decided that a tab gaining focus after another tab is closed should be automatically unsuspended...But it doesn't seem to work for me! Has something changed w/more recent versions of MacOS or Chrome? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#519 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcJRl5myWpCZ6NHepbIaZR-3C_qVYiVOks5txiA_gaJpZM4NyNxF> .

[smilejack1]

Has never worked for me, either.

[draarong]

Hey @deanoemcke , did you know that this function isn't working, at least on MacOS?

[mcmasjc3]

Or on Windows 10. Jim McMaster mailto:[email protected]

…

On Sat, May 12, 2018, 11:25 PM draarong ***@***.***> wrote: Hey @deanoemcke <https://github.com/deanoemcke> , did you know that this function isn't working, at least on MacOS? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#519 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcJRlzhqw41aufZs46yr5Xe30Kxe1YRyks5tx8PkgaJpZM4NyNxF> .

[deanoemcke]

@draarong @mcmasjc3 @smilejack1
really? it seems to work for me?
just to confirm:

• you have 'Automatically unsuspend tab when it is viewed' checked.
• you visit a suspended tab by clicking on it.
• it automatically unsuspends.
• you close that tab and chrome brings another suspended tab in focus.
• this tab does not automatically unsuspend?

this is working fine for me on v7.0.90. ie: it does automatically unsuspend the tab in the last step.

can each of you please go through the above steps and confirm that this does not work? and also record the version of the extension you are using?

thanks!

[mcmasjc3]

It does indeed work. Thank you. I checked the Settings several times to see if there was an option that enabled this behavior. The last time I checked it was not there. Jim McMaster mailto:[email protected]

…

On Wed, May 23, 2018 at 12:08 PM, Dean Oemcke ***@***.***> wrote: @draarong <https://github.com/draarong> @mcmasjc3 <https://github.com/mcmasjc3> @smilejack1 <https://github.com/smilejack1> really? it seems to work for me? just to confirm: - you have 'Automatically unsuspend tab when it is viewed' checked. - you visit a suspended tab by clicking on it. - it automatically unsuspends. - you close that tab and chrome brings another suspended tab in focus. - this tab *does not* automatically unsuspend? this is working fine for me on v7.0.90. ie: it *does* automatically unsuspend the tab in the last step. can each of you please go through the above steps and confirm that this does not work? and also record the version of the extension you are using? thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#519 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcJRl3hExtgl5jpuUAUxDuBtSfnWVhZkks5t1aWwgaJpZM4NyNxF> .

[mcmasjc3]

I take it back. It works on my Linux machine at work, but not on my Windows 10 laptop. The case might be a bit different, though. I have several tabs open and am working through them, closing them as I go. Eventually, some of the tabs suspend while I am reading the article in the focused tab. When I close that one, the newly-focused tab does not unsuspend. Jim McMaster mailto:[email protected]

…

On Wed, May 23, 2018, 2:45 PM Jim McMaster ***@***.***> wrote: It does indeed work. Thank you. I checked the Settings several times to see if there was an option that enabled this behavior. The last time I checked it was not there. Jim McMaster ***@***.*** On Wed, May 23, 2018 at 12:08 PM, Dean Oemcke ***@***.***> wrote: > @draarong <https://github.com/draarong> @mcmasjc3 > <https://github.com/mcmasjc3> @smilejack1 <https://github.com/smilejack1> > really? it seems to work for me? > just to confirm: > > - you have 'Automatically unsuspend tab when it is viewed' checked. > - you visit a suspended tab by clicking on it. > - it automatically unsuspends. > - you close that tab and chrome brings another suspended tab in focus. > - this tab *does not* automatically unsuspend? > > this is working fine for me on v7.0.90. ie: it *does* automatically > unsuspend the tab in the last step. > > can each of you please go through the above steps and confirm that this > does not work? and also record the version of the extension you are using? > > thanks! > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#519 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AcJRl3hExtgl5jpuUAUxDuBtSfnWVhZkks5t1aWwgaJpZM4NyNxF> > . >

[t0m05]

it requests that suspended tabs that gain focus after anther tab is closed should not automatically unsuspend. i agreed with the user at the time, hence the change in functionality.
it's not a bug, it's a feature!
i guess the long-term solution is to have this as a configurable option.

After some deliberation, I have decided to revert this functionality back to how it used to be. Any suspended tab that gains focus will now automatically reload, regardless of whether the focus was gained via the closing of another tab.
The main reason for this decision was consistency. It appeared to be too much like a bug the way it currently operated. And I'm not sure the number of people in favour or against this feature is significant either way.

I recently got the update and think TGS is generally one of the greatest extensions I use.
However, when it comes to this issue, I have to say I prefer the previous functionality. I don't see why closing one tab should unsuspend the next (unrelated) tab to get focus.
I accept that others have voiced a different opinion based on their workflow, so I would be all for it being a configurable option.

[deanoemcke]

@t0m05 i have created a new issue requesting the ability to make this a configurable behaviour: #747

[t0m05]

@t0m05 i have created a new issue requesting the ability to make this a configurable behaviour: #747

Thanks! 👍

[mcmasjc3]

This still doesn't work for me on the latest version of Chrome on Windows. It works fine on Linux and Mac. Jim McMaster mailto:[email protected]

…

On Tue, Feb 5, 2019, 9:06 PM Dean Oemcke ***@***.*** wrote: Closed #519 <#519>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#519 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcJRl2AU2qqySm2dAXXs-MBZk_r9QS8Rks5vKlS5gaJpZM4NyNxF> .

[deanoemcke]

@mcmasjc3 Can you please check a few things for me?

1. Tell me the version of TGS you are using
2. Ensure 'Automatically unsuspend tab when it is viewed' is checked
3. Open a new chrome window and navigate to a website and then suspend that tab while looking at it
4. Create a new tab in that same window (so you have just 2 tabs in that window) and then close it again immediately.
5. Confirm that the suspended tab unsuspends automatically (or not :/ )

Thanks :)

[mcmasjc3]

The version I had on my Windows machine is v6.30, which is much lower than the one I have on my Mac at work. I removed and re-added the extension and now I have v7.0.109. That was the problem. I don't know why TGS wasn't updating automatically. Thank you, and sorry for the trouble. Jim McMaster mailto:[email protected]

…

On Wed, Feb 6, 2019 at 3:44 PM Dean Oemcke ***@***.***> wrote: @mcmasjc3 <https://github.com/mcmasjc3> Can you please check a few things for me? 1. Tell me the version of TGS you are using 2. Ensure 'Automatically unsuspend tab when it is viewed' is checked 3. Open a new chrome window and navigate to a website and then suspend that tab while looking at it 4. Create a new tab in that same window (so you have just 2 tabs in that window) and then close it again immediately. 5. Confirm that the suspended tab unsuspends automatically (or not :/ ) Thanks :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#519 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcJRl40jAC8U3qE-bSkLtxWpAc5X8iTdks5vK1regaJpZM4NyNxF> .