feat(design)!: change daffColorMixin
to a directive
#2942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
An
ElementRef
andRenderer
need to be constructed for thedaffColorMixin
to be extendable or usable in a component.Part of: #2911
What is the new behavior?
Removed
daffColorMixin
in favor ofDaffColorableDirective
so that a component can use the directive by adding it as ahostDirective
. This reduces code complexity.Updated error to a warning because erroring causes button to not display correctly, and a warning will just default the button color to the base that's set.
Dependent on #2913, #2919, #2922, #2923, #2925, #2937, #2941 to be merged first.
Does this PR introduce a breaking change?
BREAKING CHANGE:
daffColorMixin
has been removed in favor ofDaffColorableDirective
. Update usage by using thehostDirective
feature.Other information