Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: change daffManageContainerLayoutMixin to a directive #2919

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jul 18, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

An ElementRef and Renderer need to be constructed for the daffManageContainerLayoutMixin to be extendable or usable in a component.

Part of: #2911

What is the new behavior?

Removed daffManageContainerLayoutMixin in favor of DaffManageContainerLayoutDirective so that a component can use the directive by adding it as a hostDirective. This reduces code complexity.

Dependent on #2913 to be merged first.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE: daffManageContainerLayoutMixin has been removed in favor of DaffManageContainerLayoutDirective. Update usage by using the hostDirective feature.

Other information

BREAKING CHANGE: daffManageContainerLayoutMixin has been removed in favor of DaffManageContainerLayoutDirective. Update usage by using the hostDirective feature.
@damienwebdev damienwebdev force-pushed the manage-container-mixin-to-directive branch from c2111b3 to 8da0adf Compare July 30, 2024 15:53
@damienwebdev damienwebdev merged commit 98f19c8 into develop Jul 30, 2024
3 checks passed
@damienwebdev damienwebdev deleted the manage-container-mixin-to-directive branch July 30, 2024 15:54
@gray-bot gray-bot mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants