Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all)!: simplify and remove redundant generics #2791

Merged
merged 1 commit into from
May 14, 2024

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

The multitude of generics (especially in cart) was overwhelming and unnecessary. Customization of the root model DaffCart is all that is necessary to correctly type everything that is a child of DaffCart (so not DaffCartOrderResult) in the package.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Changes the type params to many parts of @daffodil/cart/state.

Other information

@griest024 griest024 added package: cart @daffodil/cart layer: state This PR or issue is related to the redux state layer status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels May 13, 2024
@griest024 griest024 self-assigned this May 13, 2024
@griest024 griest024 requested review from a team as code owners May 13, 2024 18:44
@griest024 griest024 force-pushed the feat/all/simplify-generics branch from 1d10da3 to f95a267 Compare May 13, 2024 19:23
@griest024 griest024 force-pushed the feat/all/simplify-generics branch from f95a267 to 13d0e2d Compare May 14, 2024 02:39
@griest024 griest024 merged commit 40eee41 into graycoreio:develop May 14, 2024
31 checks passed
@griest024 griest024 deleted the feat/all/simplify-generics branch May 14, 2024 02:46
@gray-bot gray-bot mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer: state This PR or issue is related to the redux state layer package: cart @daffodil/cart status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant