Skip to content

Commit

Permalink
feat(all): simplify and remove redundant generics (#2791)
Browse files Browse the repository at this point in the history
  • Loading branch information
griest024 authored May 14, 2024
1 parent e300d70 commit 40eee41
Show file tree
Hide file tree
Showing 12 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion libs/contact/driver/in-memory/src/contact.service.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ describe('The DaffInMemoryContactService', () => {
],
});
httpMock = TestBed.inject(HttpTestingController);
contactService = TestBed.inject<DaffInMemoryContactService>(DaffInMemoryContactService);
contactService = TestBed.inject(DaffInMemoryContactService);
});

afterEach(() => {
Expand Down
2 changes: 1 addition & 1 deletion libs/customer/state/src/effects/customer.effects.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ describe('@daffodil/customer/state | DaffCustomerEffects', () => {

effects = TestBed.inject<DaffCustomerEffects<DaffCustomer>>(DaffCustomerEffects);
daffDriver = TestBed.inject<DaffCustomerDriverInterface>(DaffCustomerDriver);
customerFactory = TestBed.inject<DaffCustomerFactory>(DaffCustomerFactory);
customerFactory = TestBed.inject(DaffCustomerFactory);

mockCustomer = customerFactory.create();

Expand Down
2 changes: 1 addition & 1 deletion libs/design/modal/src/service/specs/modal.service.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe('@daffodil/design/modal | DaffModalService', () => {

beforeEach(() => {
service = TestBed.inject(DaffModalService);
overlayContainer = TestBed.inject<OverlayContainer>(OverlayContainer);
overlayContainer = TestBed.inject(OverlayContainer);
overlayContainerElement = overlayContainer.getContainerElement();
fixture = TestBed.createComponent(WrapperComponent);
fixture.detectChanges();
Expand Down
2 changes: 1 addition & 1 deletion libs/design/modal/src/service/specs/multiple-modal.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe('@daffodil/design/modal | DaffModalService', () => {
}).compileComponents();

modalService = TestBed.inject(DaffModalService);
overlayContainer = TestBed.inject<OverlayContainer>(OverlayContainer);
overlayContainer = TestBed.inject(OverlayContainer);
overlayContainerElement = overlayContainer.getContainerElement();
fixture = TestBed.createComponent(WrapperComponent);
fixture.detectChanges();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('@daffodil/external-router/driver/in-memory | DaffExternalRouterInMemor
TestBed.configureTestingModule({
imports: [DaffExternalRouterDriverInMemoryModule.forRoot(configuration)],
});
service = TestBed.inject<DaffExternalRouterInMemoryDriver>(DaffExternalRouterInMemoryDriver);
service = TestBed.inject(DaffExternalRouterInMemoryDriver);

scheduler = new TestScheduler((actual, expected) => {
expect(actual).toEqual(expected);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('@daffodil/external-router/driver/testing | DaffExternalRouterTestingDr
TestBed.configureTestingModule({
imports: [DaffExternalRouterDriverTestingModule.forRoot(configuration)],
});
service = TestBed.inject<DaffExternalRouterTestingDriver>(DaffExternalRouterTestingDriver);
service = TestBed.inject(DaffExternalRouterTestingDriver);

scheduler = new TestScheduler((actual, expected) => {
expect(actual).toEqual(expected);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ describe('@daffodil/external-router/routing | DaffExternalRouterExistenceGuard',
]),
],
});
router = TestBed.inject<Router>(Router);
guard = TestBed.inject<DaffExternalRouterExistenceGuard>(DaffExternalRouterExistenceGuard);
router = TestBed.inject(Router);
guard = TestBed.inject(DaffExternalRouterExistenceGuard);
driver = TestBed.inject(DaffExternalRouterDriver);

});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('@daffodil/external-router | daffConvertToPath', () => {
imports: [RouterTestingModule],
});

router = TestBed.inject<Router>(Router);
router = TestBed.inject(Router);
});

it('convert a segments array to a path', () => {
Expand Down
4 changes: 2 additions & 2 deletions libs/external-router/src/router/router.service.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ describe('@daffodil/external-router | DaffExternalRouter', () => {
TestBed.overrideProvider(DAFF_EXTERNAL_ROUTER_ROUTES_RESOLVABLE_BY_TYPE, {
useValue: types,
});
service = TestBed.inject<DaffExternalRouter>(DaffExternalRouter);
router = TestBed.inject<Router>(Router);
service = TestBed.inject(DaffExternalRouter);
router = TestBed.inject(Router);
};

it('should be created', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ describe('@daffodil/external-router | daffTransformResolvedRouteToRoute', () =>
imports: [RouterTestingModule],
});

router = TestBed.inject<Router>(Router);
router = TestBed.inject(Router);
});

it('transforms a DaffExternallyResolvableUrl into an Angular route.', () => {
Expand Down
2 changes: 1 addition & 1 deletion libs/geography/state/src/effects/geography.effects.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ describe('Daffodil | Geography | GeographyEffects', () => {

effects = TestBed.inject<DaffGeographyEffects<DaffCountry>>(DaffGeographyEffects);
daffDriver = TestBed.inject(DaffGeographyDriver);
countryFactory = TestBed.inject<DaffCountryFactory>(DaffCountryFactory);
countryFactory = TestBed.inject(DaffCountryFactory);

mockCountry = countryFactory.create();
countryId = mockCountry.id;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe('Driver | InMemory | Newsletter | NewsletterService', () => {
],
});
httpMock = TestBed.inject(HttpTestingController);
newsletterService = TestBed.inject<DaffInMemoryNewsletterService>(DaffInMemoryNewsletterService);
newsletterService = TestBed.inject(DaffInMemoryNewsletterService);
});

afterEach(() => {
Expand Down

0 comments on commit 40eee41

Please sign in to comment.