Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethereum: Support Celo block reward events #2670

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

leoyvens
Copy link
Collaborator

Celo has special events that have the transaction hash == block hash and are returned from eth_getLogs but not included as transaction receipts. See code comments for details.

Closes #2648. Closes #2353.

@leoyvens leoyvens requested a review from lutter July 30, 2021 13:01
@leoyvens leoyvens force-pushed the leo/support-celo-epoch-rewards branch from 7eb3da5 to 1575f3a Compare July 30, 2021 13:22
@leoyvens leoyvens removed the request for review from lutter August 2, 2021 11:54
Copy link
Contributor

@Jannis Jannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, interesting construction.

@leoyvens leoyvens merged commit 1fa8956 into master Aug 2, 2021
@leoyvens leoyvens deleted the leo/support-celo-epoch-rewards branch August 2, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants