Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revist Celo detection #2742

Open
leoyvens opened this issue Aug 26, 2021 · 0 comments
Open

Revist Celo detection #2742

leoyvens opened this issue Aug 26, 2021 · 0 comments

Comments

@leoyvens
Copy link
Collaborator

#2670 introduced logic that checks the chain_id to see if it is Celo, and in that case it sets the reorg threshold to zero. But we would like to change how that is done. It is currently implemented inefficiently because the call is done every time a block stream is constructed, instead of once per provider, so that can be optimized. Another consideration is that it would be generally useful to have a per-provider configuration of the reorg threshold, in which case the necessity of any chain id based detection is questionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant