Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding Router.Name to create new Route #457

Merged
merged 1 commit into from
Feb 28, 2019
Merged

adding Router.Name to create new Route #457

merged 1 commit into from
Feb 28, 2019

Conversation

seriousben
Copy link
Contributor

Fixes #456

@seriousben seriousben force-pushed the router-create-route-by-name branch from e2c55f8 to 296d698 Compare February 27, 2019 19:22
@seriousben
Copy link
Contributor Author

seriousben commented Feb 27, 2019 •
edited
Loading

The go vet issue is fixed in #458

@seriousben seriousben mentioned this pull request Feb 28, 2019
Merged
@seriousben seriousben force-pushed the router-create-route-by-name branch from 296d698 to 3acaa45 Compare February 28, 2019 17:53
@kisielk kisielk merged commit 15a353a into gorilla:master Feb 28, 2019
@kisielk
Copy link
Contributor

kisielk commented Feb 28, 2019

Cool, thanks for this and the travis update.

@seriousben seriousben deleted the router-create-route-by-name branch February 28, 2019 18:16
@KattMingMing KattMingMing mentioned this pull request Apr 9, 2019
Closed
thaJeztah added a commit to thaJeztah/cli that referenced this pull request Jun 20, 2019
@thaJeztah
bump gorilla/mux v1.7.2
81e3457 
full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

 - gorilla/mux#457 adding Router.Name to create new Route
 - gorilla/mux#447 host:port matching does not require a :port to be specified

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah mentioned this pull request Jun 20, 2019
Merged
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Jun 20, 2019
@thaJeztah
bump gorilla/mux v1.7.2
25b451e 
full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

 - gorilla/mux#457 adding Router.Name to create new Route
 - gorilla/mux#447 host:port matching does not require a :port to be specified

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah mentioned this pull request Jun 20, 2019
Merged
@thaJeztah thaJeztah mentioned this pull request Jun 26, 2019
Merged
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Jun 26, 2019
@thaJeztah
bump gorilla/mux v1.7.2
be5872c 
full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

 - gorilla/mux#457 adding Router.Name to create new Route
 - gorilla/mux#447 host:port matching does not require a :port to be specified

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Upstream-commit: 25b451e01b8a1b44f45a67cb4731ff61d7b1ebc1
Component: engine
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Aug 27, 2019
@thaJeztah
bump gorilla/mux v1.7.2
6d45c02 
full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

 - gorilla/mux#457 adding Router.Name to create new Route
 - gorilla/mux#447 host:port matching does not require a :port to be specified

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 25b451e)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Sep 6, 2019
@thaJeztah
bump gorilla/mux v1.7.2
3d74308 
full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

 - gorilla/mux#457 adding Router.Name to create new Route
 - gorilla/mux#447 host:port matching does not require a :port to be specified

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Upstream-commit: 81e3457c23630de470c42d909e79dfb159833f7a
Component: cli
aiordache pushed a commit to aiordache/cli that referenced this pull request Sep 20, 2019
@thaJeztah
bump gorilla/mux v1.7.2
9f44dc3 
full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

 - gorilla/mux#457 adding Router.Name to create new Route
 - gorilla/mux#447 host:port matching does not require a :port to be specified

Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Sep 20, 2019
@thaJeztah
bump gorilla/mux v1.7.2
486953e 
full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

 - gorilla/mux#457 adding Router.Name to create new Route
 - gorilla/mux#447 host:port matching does not require a :port to be specified

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 25b451e)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Sep 24, 2019
@thaJeztah
bump gorilla/mux v1.7.2
cd8f85f 
full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

 - gorilla/mux#457 adding Router.Name to create new Route
 - gorilla/mux#447 host:port matching does not require a :port to be specified

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 25b451e01b8a1b44f45a67cb4731ff61d7b1ebc1)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Upstream-commit: 486953e2ff065883897746317c318b0bb8d3406d
Component: engine
burnMyDread pushed a commit to burnMyDread/moby that referenced this pull request Oct 21, 2019
@thaJeztah @burnMyDread
bump gorilla/mux v1.7.2
d50e047 
full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

 - gorilla/mux#457 adding Router.Name to create new Route
 - gorilla/mux#447 host:port matching does not require a :port to be specified

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: zach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seriousben @kisielk