Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump gorilla/mux v1.7.2 #1958

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Conversation

thaJeztah
Copy link
Member

full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

 - gorilla/mux#457 adding Router.Name to create new Route
 - gorilla/mux#447 host:port matching does not require a :port to be specified

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #1958 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1958   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files         310      310           
  Lines       21800    21800           
=======================================
  Hits        12367    12367           
  Misses       8518     8518           
  Partials      915      915

@thaJeztah
Copy link
Member Author

@silvin-lubecki @vdemeester ptal

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌞

@thaJeztah
Copy link
Member Author

ping @silvin-lubecki PTAL

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 016a323 into docker:master Sep 6, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.09.0 milestone Sep 6, 2019
@thaJeztah thaJeztah deleted the bump_gorilla_mux branch September 24, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants