Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrisaljoudi #2847

Closed
wants to merge 288 commits into from
Closed

Chrisaljoudi #2847

wants to merge 288 commits into from

Conversation

MarcoBey
Copy link

@MarcoBey MarcoBey commented Aug 7, 2017

Mustafa Hasturk and others added 30 commits April 2, 2015 10:08
…f onLocationChange occurring before document-element-inserted
Corrected links gorhill -> chrisaljoudi
…f onLocationChange occurring before document-element-inserted
chrisaljoudi and others added 27 commits May 16, 2015 18:26
this fixes overlooked code change in 1d3205e
(maintain reverse lookup map of tabs by tab ID rather than searching through all tabs to find by ID)
…en that window is closed. Made getTabForBrowser robust to being called for orphaned tab browsers.
@bershan2
Copy link
Contributor

bershan2 commented Aug 7, 2017

@MarcoBey Why are you proposing to merge the Chrisaljoudi's branch? They have separated a while ago and this repository contains numerous updates, fixes, and improvements. They are absolutely incompatible. E.g., .travis.yml contains Chrisaljoudi's key, which would not even allow to publish the release. What is the point of this pull request?

@gorhill gorhill closed this Aug 7, 2017
Copy link

@manoon2410 manoon2410 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.