Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Pale Moon) A minor bug with the "Block media elements" function #1448

Closed
LimboSlam opened this issue Mar 5, 2016 · 3 comments
Closed

(Pale Moon) A minor bug with the "Block media elements" function #1448

LimboSlam opened this issue Mar 5, 2016 · 3 comments

Comments

@LimboSlam
Copy link

I've notice this ever since uBlock Origin v1.6.0 introduced this new functionality. It seems the scroll buttons are missing and when I try to change the value, it gets unchecked/disabled. I'm using Pale Moon v26.1.1 x64 on Windows 8.1.

Here are some screenshots:

Pale Moon, just hovering over the Block media elements function
pale moon

Pale Moon, changing the value of it
pale moon changing value

Firefox ESR v38.6.1, scroll buttons appear as should:
firefox esr

Firefox ESR v38.6.1, changing the value functions as normal:
firefox esr changing the value

Google Chrome v49, scroll buttons and changing the value function normally:
google chrome changing value

Hope this is enough information. If more is needed, let me know.

@gorhill
Copy link
Owner

gorhill commented Mar 6, 2016

<input> tags support for type number was introduced in Firefox 29.

The focus issue is not present with Firefox or Chromium, I will consider this a browser bug. Workaround, double-click on the value to change it.

@gorhill gorhill closed this as completed Mar 6, 2016
@gorhill
Copy link
Owner

gorhill commented Mar 6, 2016

Re. the focus issue, as per standard, content model of label elements:

Phrasing content, but with no descendant labelable elements unless it is the element's labeled control, and no descendant label elements.

So the input element should not be a descendant of the label element. But this would overly complicate the localization code. I will try to find a workaround.

@gorhill gorhill reopened this Mar 6, 2016
@gorhill gorhill closed this as completed in c91c91f Mar 6, 2016
@LimboSlam
Copy link
Author

Nice! I can't wait for the next release!

Thanks @gorhill!

gorhill pushed a commit that referenced this issue Sep 26, 2016
…en that window is closed. Made getTabForBrowser robust to being called for orphaned tab browsers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@gorhill @LimboSlam and others