build(owlbot-php): install @prettier/plugin-php #1416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmatsuo
requested review from
SurferJeffAtGoogle,
chingor13,
bcoe and
a team
as code owners
tmatsuo
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
bcoe
reviewed
Apr 12, 2022
| @@ -39,6 +39,9 @@ ENV SYNTHTOOL_TEMPLATES="/synthtool/synthtool/gcp/templates" | |||
| ENV npm_config_cache=/tmp/.npm | |||
| RUN mkdir /tmp/.npm && chmod 1777 /tmp/.npm | |||
|
|
|||
| # Install @prettier/plugin-php | |||
| RUN npm install --global prettier @prettier/plugin-php@^0.18.4 | |||
There was a problem hiding this comment.
I might make this 0.8.4 rather than ^0.18.4.
There was a problem hiding this comment.
(otherwise it's hard to know specifically what patch version we might have gotten).
bcoe
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1415