Post-processor container relies on external dependency

[bcoe]

Problem

The PHP post-processor container has a dependency on an external dependency installed from npm:

Step googleapis/repo-automation-bots#1:   - TLSSocket
Step googleapis/repo-automation-bots#1:   - TLSSocket
Step googleapis/repo-automation-bots#1:   - Socket
Step googleapis/repo-automation-bots#1:   - Socket
Step googleapis/repo-automation-bots#1:   - Socket
Step googleapis/repo-automation-bots#1: Active handles:
Step googleapis/repo-automation-bots#1: Process stalled
Step googleapis/repo-automation-bots#1: error An unexpected error occurred: "https://registry.npmjs.org/prettier/-/prettier-2.2.1.tgz: unexpected end of file".
Step googleapis/repo-automation-bots#1:  (warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove 

This makes it susceptible to intermittent network issues on the upstream registry. It also makes it possible that we have a nested dependency break, if we're not using a package-lock.json during installation.

Possible solution

Install prettier into container when building.

[saranshdhingra]

Hi @bcoe
Considering we have moved to owlbot, just wanted to confirm if this is still relevant?

[bcoe]

@saranshdhingra this still can potentially be an issue. OwlBot runs the post-processor.

[bshaffer]

This refers to how we have owlbot.py run the following in ~110 of our generated clients (out of 178).

For example, in BareMetalSolution/owlbot.py:

# format generated clients
subprocess.run([
    'npm',
    'exec',
    '--yes',
    '--package=@prettier/plugin-php@^0.16',
    '--',
    'prettier',
    '**/Gapic/*',
    '--write',
    '--parser=php',
    '--single-quote',
    '--print-width=80'])

This seems like something that would make sense to be part of the gapic generator, and then we can remove it from owlbot entirely.