Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixing renovate config #2093

Merged
merged 1 commit into from
Oct 11, 2023
Merged

chore: Fixing renovate config #2093

merged 1 commit into from
Oct 11, 2023

Conversation

ddixit14
Copy link
Contributor

@ddixit14 ddixit14 commented Oct 11, 2023

All configuration as per https://docs.renovatebot.com/configuration-options/.

Might fix #2067
(Will re-open the issue if it gets closed and this fix doesn't work).

@ddixit14 ddixit14 requested a review from a team as a code owner October 11, 2023 19:08
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 11, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@blakeli0
Copy link
Collaborator

Can you briefly explain why it stopped working previously? And how did you test this fix? Or it was not tested?

@ddixit14
Copy link
Contributor Author

Can you briefly explain why it stopped working previously? And how did you test this fix? Or it was not tested?

We temporarily stopped it for sometime post the migration to monorepo. Then opened it back. It should have worked ideally, I don't know the reason why it didn't. As first steps, I made sure that the configuration is as per the documentation, hence this PR.
This fix is not tested yet. Once this is merged, then we'll see if we are getting the updates or not. If not, then I will dig further.

@ddixit14 ddixit14 merged commit 055ac83 into main Oct 11, 2023
36 checks passed
@ddixit14 ddixit14 deleted the fix-renovate branch October 11, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renovate bot stopped working
3 participants