Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ignore all exceptions from CancelOperation #1713

Merged
merged 6 commits into from
Feb 24, 2022
Merged

test: ignore all exceptions from CancelOperation #1713

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f43a9e1
test: ignore all exceptions from CancelOperation
rajatbhatta Feb 24, 2022
d08fda9
fix: change comment
rajatbhatta Feb 24, 2022
82514e2
fix: change comment
rajatbhatta Feb 24, 2022
4fba95d
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 24, 2022
762ab99
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 24, 2022
40ab4a1
Merge branch 'fix-test-issue-1652-1' of https://github.com/rajatbhatt…
gcf-owl-bot[bot] Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/slow/ITBackupTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,11 +468,7 @@ public void test02_RetryNonIdempotentRpcsReturningLongRunningOperations() throws
try {
client.cancelOperation(op.getName());
} catch (SpannerException e) {
// Ignore UNIMPLEMENTED errors, as it seems that Cloud Spanner cannot cancel a restore
// operation that has already started.
if (e.getErrorCode() != ErrorCode.UNIMPLEMENTED) {
throw e;
}
// Ignore, this is expected as it cannot find the backup that we are trying to restore.
rajatbhatta marked this conversation as resolved.
Show resolved Hide resolved
}
// Assert that the RestoreDatabase RPC was called only once, and that the operation
// tracking was resumed through a GetOperation call.
Expand Down