Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ignore all exceptions from CancelOperation #1713

Merged
merged 6 commits into from
Feb 24, 2022
Merged

test: ignore all exceptions from CancelOperation #1713

merged 6 commits into from
Feb 24, 2022

Conversation

rajatbhatta
Copy link
Contributor

@rajatbhatta rajatbhatta commented Feb 24, 2022 •
edited
Loading

Ignore all exceptions arising from CancelOperation for RestoreDatabase call.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1652 ☕️

@rajatbhatta
test: ignore all exceptions from CancelOperation
f43a9e1 
Ignore all exceptions arising from CancelOperation for RestoreDatabase call.
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Feb 24, 2022
@rajatbhatta rajatbhatta marked this pull request as ready for review February 24, 2022 16:23
@rajatbhatta rajatbhatta requested a review from a team as a code owner February 24, 2022 16:23
olavloite
olavloite approved these changes Feb 24, 2022
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added a suggestion for the comment, but feel free to ignore that if you feel that it does not make it clearer.

google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/slow/ITBackupTest.java Outdated Show resolved Hide resolved
@rajatbhatta @olavloite
fix: change comment
82514e2 
Co-authored-by: Knut Olav Løite <[email protected]>
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2022
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2022
@rajatbhatta rajatbhatta requested a review from a team as a code owner February 24, 2022 18:29
@rajatbhatta rajatbhatta merged commit b8c67ae into googleapis:main Feb 24, 2022
@rajatbhatta rajatbhatta deleted the fix-test-issue-1652-1 branch February 24, 2022 19:05
ansh0l
ansh0l reviewed Feb 24, 2022
View reviewed changes
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@rajatbhatta rajatbhatta self-assigned this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansh0l ansh0l ansh0l left review comments

@olavloite olavloite olavloite approved these changes

Assignees

@rajatbhatta rajatbhatta

Labels
api: spanner Issues related to the googleapis/java-spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner.it.slow.ITBackupTest: test02_RetryNonIdempotentRpcsReturningLongRunningOperations failed
3 participants
@rajatbhatta @olavloite @ansh0l