Unify browser test files and add safari tests #88
+293
−372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
approved these changes
Mar 4, 2024
jonasfj
approved these changes
Mar 4, 2024
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
|
Thanks! This is awesome. hmm, sad to see the iOS integration tests failing so frequently. I'll file a bug, someday it might be worth fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #86 (review)
As a test for
crypto_subtle.dart, I have combined them into one test file.By specifying
test.testOn, different expectations are expressed in chrome, firefox and safari.https://pub.dev/documentation/test/latest/test/test.html
I checked and got an
OperationErrorwhen publicExponent isUint8List.fromList([0x03])in macOS + safari. I added a test case tocrypto_subtle_dart.dart, but it seems difficult to include macOS + safari in thewebcrypto_test.darttest target.And on macOS, the firefox test cannot be run due to the following issue.
dart-lang/test#2194
Due to these reasons, I have not made any changes to the workflows.