Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox fails to start when called via /Applications/Firefox.app/Contents/MacOS/firefox-bin on macOS #2194

Closed
koji-1009 opened this issue Mar 2, 2024 · 1 comment

Comments

@koji-1009
Copy link

When I try to run the test code for the browser API, I cannot run the test using firefox.
Note that if -p chrome is specified, it works fine.

$ dart test -p firefox
00:03 +0: loading test/crypto_subtle_test.dart
Compiled 11,501,289 input bytes (6,524,318 characters source) to 1,333,060 characters JavaScript in 3.08 seconds using 323.453 MB of memory

00:03 +0 -1: loading test/crypto_subtle_test.dart [E]
  Failed to load "test/crypto_subtle_test.dart":
  Failed to run Firefox: No such file or directory
    Command: /Applications/Firefox.app/Contents/MacOS/firefox-bin --profile /private/var/folders/hr/y37hfwp553b_1bc41k7s8nqm0000gn/T/dart_test_JsusyQ http://localhost:57615/rxxgE01iInxRSACwP2MzZZtXA6TVPGX2/packages/test/src/runner/browser/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A57615%2FrxxgE01iInxRSACwP2MzZZtXA6TVPGX2%2F0&debug=false --no-remote.
  dart:io-patch/process_patch.dart 402:33                      _ProcessImpl._start
  dart:io-patch/process_patch.dart 38:20                       Process.start
  package:test/src/runner/browser/firefox.dart 44:33           Firefox._startBrowser
  package:test/src/runner/browser/firefox.dart 35:13           new Firefox.<fn>
  package:test/src/runner/browser/browser.dart 61:39           new Browser.<fn>
  dart:async/zone.dart 1399:13                                 _rootRun
  dart:async/zone.dart 1301:19                                 _CustomZone.run
  dart:async/zone.dart 1804:10                                 _runZoned
  dart:async/zone.dart 1792:12                                 runZonedGuarded
  package:test/src/runner/browser/browser.dart 60:5            new Browser
  package:test/src/runner/browser/firefox.dart 34:9            new Firefox
  package:test/src/runner/browser/browser_manager.dart 161:28  BrowserManager._newBrowser
  package:test/src/runner/browser/browser_manager.dart 117:19  BrowserManager._start
  package:test/src/runner/browser/browser_manager.dart 107:7   BrowserManager.start
  package:test/src/runner/browser/platform.dart 438:33         BrowserPlatform._browserManagerFor
  package:test/src/runner/browser/platform.dart 277:32         BrowserPlatform.load
  ===== asynchronous gap ===========================
  package:test_core/src/runner/loader.dart 227:27              Loader.loadFile.<fn>
  ===== asynchronous gap ===========================
  package:test_core/src/runner/load_suite.dart 98:19           new LoadSuite.<fn>.<fn>

According to Bugzilla, Firefox 121 and later versions require the use of firefox instead of firefox-bin.

Looking at GitHub runner, macos-latest has Firefox 122.0.1 installed.

https://github.com/actions/runner-images/blob/d4e0d19512a62e7f34efe68b0b85464437a31b55/images/macos/macos-12-Readme.md#browsers

The code that references firefox-bin is in the following location.

https://github.com/dart-lang/test/blob/test-v1.25.2/pkgs/test/lib/src/runner/browser/default_settings.dart#L27

my enviroment

  • MacBook Pro (Apple M1 Pro)
  • macOS 14.3.1(23D60)
  • Firefox 123.0
@koji-1009
Copy link
Author

Fixed by #2276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant