-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: run Docker dependent tests whenever possible #2029
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2029 +/- ##
==========================================
+ Coverage 77.56% 77.83% +0.27%
==========================================
Files 82 82
Lines 9673 9675 +2
==========================================
+ Hits 7503 7531 +28
+ Misses 1628 1602 -26
Partials 542 542
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
OOC, how do you verify these tests actually ran on Travis, rather than being skipped? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran locally with the travis env, our Travis script doesn't have -v
for go test
so can't tell from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions, otherwise LGTM.
I think it's worthwhile to test this at least once (like add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turning on -v
to check the tests are running/skipping correctly and will turn if off later.
Fixes #2005
All tests that require Docker container to run will run when either: